parabol icon indicating copy to clipboard operation
parabol copied to clipboard

fix: Autofocus the input in the discussion drawer when opened

Open raj360 opened this issue 2 years ago • 7 comments

Description

Fixes/Partially Fixes #6873 [Please include a summary of the changes and the related issue] Autofocus the input in the discussion drawer when opened.

Used a useRef to autofocus on the input in the discussion drawer when opened

Demo

[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • [x] Scenario A
    • Ensure the discussion input is autofocused upon getting to page

Final checklist

  • [x] I checked the code review guidelines
  • [x] I have performed a self-review of my code, the same way I'd do it for any other team member
  • [x] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • [x] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • [x] I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • [x] PR title is human readable and could be used in changelog

Thank you for the PR!

Just one issue: when you go from one discussion topic to another, the next topic do not have auto-focus. The issue is visible both in check-in meeting and retro meeting.

Here is the demo https://www.loom.com/share/093ca7715ef44ea596efbd320f85dfc6

Hey @igorlesnenko, you can take another look you comments have bee addressed.

raj360 avatar Jul 26 '22 14:07 raj360

@raj360 Thank you for working on this issue. Could you please link the original issue?

Dschoordsch avatar Jul 29 '22 07:07 Dschoordsch

@Dschoordsch the original issue is already linked in the PR description. @igorlesnenko please can you also help review this

gitstart avatar Aug 04 '22 07:08 gitstart

Hi @igorlesnenko, your comments you can give another review.

gitstart avatar Aug 30 '22 08:08 gitstart

@JimmyLv could you please take a look since Igor is out?

Dschoordsch avatar Aug 31 '22 10:08 Dschoordsch

@Dschoordsch sure, I will take a look.

JimmyLv avatar Aug 31 '22 11:08 JimmyLv

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 09 '22 15:09 sonarqubecloud[bot]

Hello @JimmyLv, @igorlesnenko, fresh review is required on this PR

gitstart avatar Sep 09 '22 15:09 gitstart

Seems stale, I pushed a rebased version as #7238

Dschoordsch avatar Sep 29 '22 16:09 Dschoordsch