parabol
parabol copied to clipboard
fix: Autofocus the input in the discussion drawer when opened
Description
Fixes/Partially Fixes #6873 [Please include a summary of the changes and the related issue] Autofocus the input in the discussion drawer when opened.
Used a useRef to autofocus on the input in the discussion drawer when opened
Demo
[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]
Testing scenarios
[Please list all the testing scenarios a reviewer has to check before approving the PR]
- [x] Scenario A
- Ensure the discussion input is autofocused upon getting to page
Final checklist
- [x] I checked the code review guidelines
- [x] I have performed a self-review of my code, the same way I'd do it for any other team member
- [x] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
- [x] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
- [x] I added the label
One Review Required
if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient' - [x] PR title is human readable and could be used in changelog
Thank you for the PR!
Just one issue: when you go from one discussion topic to another, the next topic do not have auto-focus. The issue is visible both in check-in meeting and retro meeting.
Here is the demo https://www.loom.com/share/093ca7715ef44ea596efbd320f85dfc6
Hey @igorlesnenko, you can take another look you comments have bee addressed.
@raj360 Thank you for working on this issue. Could you please link the original issue?
@Dschoordsch the original issue is already linked in the PR description. @igorlesnenko please can you also help review this
Hi @igorlesnenko, your comments you can give another review.
@JimmyLv could you please take a look since Igor is out?
@Dschoordsch sure, I will take a look.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Hello @JimmyLv, @igorlesnenko, fresh review is required on this PR
Seems stale, I pushed a rebased version as #7238