parabol icon indicating copy to clipboard operation
parabol copied to clipboard

fix: Contrast of selected highlight of the current phase is low

Open raj360 opened this issue 2 years ago • 3 comments

Description

Fixes/Partially Fixes #6176 [Please include a summary of the changes and the related issue] Fixed the difference in contrast of the current phase

Demo

[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • [ ] Scenario A
    • Ensure the Home navigational style and the selected phase are the same

Final checklist

  • [x] I checked the code review guidelines
  • [x] I have performed a self-review of my code, the same way I'd do it for any other team member
  • [x] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • [x] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • [x] I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • [x] PR title is human readable and could be used in changelog

raj360 avatar Jul 26 '22 12:07 raj360

@raj360 thanks for working on this, can you please link the original issue so we know what the description was?

Dschoordsch avatar Jul 29 '22 07:07 Dschoordsch

@Dschoordsch the original issue is already linked in the PR description. @igorlesnenko please can you also help review this

gitstart avatar Aug 04 '22 07:08 gitstart

Hey @igorlesnenko, you mind checking in once again, your reviews have been attended to.

raj360 avatar Aug 10 '22 05:08 raj360

Hey @enriquesanchez , requested changes have been implemented please take another look.

raj360 avatar Aug 16 '22 13:08 raj360

Thanks @raj360! I'm having trouble testing your branch on my local environment. Would you mind sharing a screen capture of the updates so I can see the new highlight color?

enriquesanchez avatar Aug 16 '22 21:08 enriquesanchez