parabol icon indicating copy to clipboard operation
parabol copied to clipboard

feat: add default tasks to new team

Open JimmyLv opened this issue 2 years ago • 5 comments

Description

resolved #6719

Demo

https://user-images.githubusercontent.com/4997466/182640794-9a17f482-f8b6-4352-8617-32c408fa6b8c.mp4

Testing scenarios

  • [x] create new user with the new onboarding team by default

    • create new account
    • check /tasks page
    • see 3 seed tasks, including 1 more invite task
  • [x] create new team

    • check /team page
    • see 1 seed task, including invite task, click to open a new tab, then open the invite modal.
  • [x] create new team under new org

    • check /team page
    • see 1 seed task, including invite task, click to open a new tab, then open the invite modal.

Final checklist

  • [x] I checked the code review guidelines
  • [x] I have performed a self-review of my code, the same way I'd do it for any other team member
  • [x] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • [ ] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • [x] I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • [x] PR title is human readable and could be used in changelog

JimmyLv avatar Jun 16 '22 10:06 JimmyLv

I don't think we should merge this feature, see comments here: https://github.com/ParabolInc/parabol/issues/6719#issuecomment-1165948330

mattkrick avatar Jun 24 '22 21:06 mattkrick

Based on the latest discussion at https://github.com/ParabolInc/parabol/issues/6719#issuecomment-1199362998, I implemented only 1 invite seed task and added the related tracking events, for the Amplitude funnel that we can subsequently use to track the effects of this experiment.

(cc @tianrunhe Here's something related to Metrics, could you please help to review it?)

JimmyLv avatar Aug 03 '22 15:08 JimmyLv

Thanks @igorlesnenko , it's really not technically possible to do a direct trigger the invite modal, as has been discussed before. https://github.com/ParabolInc/parabol/issues/6719#issuecomment-1179906042

btw: do you know if we have plans to migrate draft-js inside task manager to tiptap?

It's been mentioned that the "out-app" UX is not good enough, but I can't think of a better way to do it at the moment. https://github.com/ParabolInc/parabol/issues/6719#issuecomment-1205852234

These cards ideally shouldn’t open in a new tab. The links don’t support direct interactions. Any way to make this a good UX without links?

JimmyLv avatar Aug 05 '22 16:08 JimmyLv

@JimmyLv I think we have plans to migrate from draft-js everywhere at some point

igorlesnenko avatar Aug 08 '22 09:08 igorlesnenko

Deferring to product manager @jordanh

mattkrick avatar Aug 12 '22 00:08 mattkrick

I'm reviewing this now. I'll have a proposal ~Monday or ~Tuesday for how I suggest we proceed

jordanh avatar Aug 12 '22 19:08 jordanh

Ok, thank you for standing by.

When @Matt and I gave feedback on this design idea, we failed you folks in several ways. We asserted that this approach wouldn’t work. Given that we had implemented a similar seed task cards before and exposed it to statistically significant numbers, we have pretty good reason to believe this won’t work. That doesn’t mean we’re correct, however. It just means we’re very likely to be correct.

Seed tasks were first added here in 2016, and iterated on for 3 years (!) until they were removed here in 2019. The complete history can be discovered via:

git log --follow -- src/server/graphql/mutations/helpers/addSeedTasks.js

I’d love to show you the actual data for how poorly this performed, but sadly it’s rolled off of Amplitude’s data retention window.

Before merging this, I want us to make sure that we're in a position as a team to understand what the effects are. In other words, I'd like to make certain that @mattkrick and my data are, either either out of date or that the changes to the copy are statistically significant.

Could squad members answer the following?

  1. Is the hypothesis of this experiment that we believe the funnel conversion from creating a new team to sending invitations will increase? And, creating a new team to adding an integration will increase?
  2. What are those rate today? Over what time period do we have accurate data?
  3. If the rate changes after shipping this change, what do you believe that tells you? What time frame would give us good data here (rule of thumb: roughly n=400 is a 95% confidence interval)
  4. What might our next steps be (leave the task card? Improve the new team or team dashboard journey some other way?)

If you come with me on this journey, I'd like to highlight this as an example of what a good experiment could look like here for other squads

jordanh avatar Aug 15 '22 20:08 jordanh

See issue

Dschoordsch avatar Aug 17 '22 10:08 Dschoordsch

@Dschoordsch @JimmyLv, how would you like to proceed?

jordanh avatar Aug 25 '22 18:08 jordanh

@jordanh I checked the numbers and they suggest that most people don't create a new team, thus this is redundant for user activation. I closed the issue.

Dschoordsch avatar Aug 25 '22 18:08 Dschoordsch