Question regarding the output of "make test"

[wilwarindi]

I'm working on a set of requested icons, and when I use the command "make test" to check them before creating a pull request, I get this:

~/GitHub/papirus-icon-theme$ make test Searching for icons with rendering glitches Searching for non-optimized icons Papirus/48x48/apps/mihomo-party.svg Papirus/22x22/apps/mihomo-party.svg Papirus/64x64/apps/mihomo-party.svg Papirus/24x24/apps/mihomo-party.svg make: *** [Makefile:89: test_optimization] Error 1

I don't know how to interpret that error. Does "Error 1" narrow it down as to what is causing the error, or should I just remake the icons? Any ideas for what I need to fix?

Thanks.

[morganist]

see the file names in the script output? the error refers to them, as they were printed after searching for non-optimised icons. normally, the script exits silently

[SmartFinn]

To fix this error run the following commands in a terminal:

cd tools/work/
./get-from-theme.sh apps mihomo-party.svg
./prepare.sh
./put-into-theme.sh

All SVG icons in this repository should be optimized to avoid dramatically increases size of .git folder and, of course, size of the icon theme.

The test search <?xml notation in the SVG files. If ./prepare.sh doesn't fix the issues, please let me know.

[wilwarindi]

@morganist I know that, my question was what exactly is wrong with those files. Does the error code tell me what the problem is, or it only means "wrong"? If not, then how do I improve optimization? When I've ran the prepare.sh script it moves some of the layers (the square, to be specific) out of alignment. I assumed I was supposed to put it back in its place, because the icon would look weird otherwise. I've gotten the same error in other icons, and usually re-doing or re-importing the problematic layer fixes things. But it's not working this time, so I think I might ask: what does non-optimized mean, mechanically? I assume it doesn't mean it's only misaligned, but something else. How do I fix it?

[SmartFinn]

@wilwarindi could you upload these files here as a zip file? And what have you installed as an SVG optimizer? SVGO or scrour?