cannon icon indicating copy to clipboard operation
cannon copied to clipboard
verified publisher icon Papierkorb

Fix Time struct

Open srcrip opened this issue 5 years ago • 2 comments

Fixes https://github.com/Papierkorb/cannon/issues/4

srcrip avatar Jun 07 '20 19:06 srcrip

Hello, thank you for your contribution!

Cannon doesn't guarantee any kind of compatibility between versions, so it's fine to ~~wreak havoc~~ change things! :)

I think Time should carry the timezone over, including any other data it offers (Like the nanoseconds). deserialize(serialize(some_object)) == some_object should always be true as long it's feasible. Could you look into that?

Cheers!

Papierkorb avatar Jun 07 '20 19:06 Papierkorb

OK I made some changes I think are good. I'm not quite sure if I've done it correctly though.

srcrip avatar Jun 07 '20 21:06 srcrip