extensions-common icon indicating copy to clipboard operation
extensions-common copied to clipboard

[Bug] Errors in Languages interface

Open AdrienSeon opened this issue 5 years ago • 0 comments

It seems there are some errors in the Languages interface for the following constants:

  • CHINESE
  • CHINESE_HONGKONG
  • ISRAELI
  • MEXICAN

Some other mentions:

  • INDIAN should be HINDI
  • Brazilian doesn't exist, its Portuguese
  • Mexican doesn't exist, its Spanish
  • Malay doesn't exist, if it was intended for Malaysia, it's English
  • For Iran it should be PERSIAN with "fa"
  • For Philippine it should be FILIPINO and there's only ISO 939-2 three-letter code "fil"
  • ISRAELI is not a valid ISO 939-1 code, it should be Hebrew with "he"

And if we want to be accurate with ISO 939-1 two-letter codes (don't know how it's used app side) here are some other adjustments:

  • Chinese is not really accurate for ISO 939-1 but might be OK depending on how it's used app side
  • For Czech it should be "cs" conforming to ISO 939-1
  • Danish should be "da" conforming to ISO 939-1
  • Welsh should be "cy" conforming to ISO 939-1
  • Greek should be "el" conforming to ISO 939-1
  • CHINEESE_HONGKONG = 'hk' is not a valid ISO 939-1 code
  • Japanese should be "ja" conforming to ISO 939-1
  • Korean should be "ko" conforming to ISO 939-1
  • SAMI = 'si' isn't a valid ISO 939-1 code, there is ISO 939-2 code "smi" though. There is Northern Sami with "se" which is the most widely spoken of all Sami languages.
  • Ukrainian should be "uk" conforming to ISO 939-1
  • Vietnamese should be "vi"
  • English should be "en" conforming to ISO 939-1

ISO 939-1 wiki link for reference

AdrienSeon avatar Mar 15 '21 22:03 AdrienSeon