docs icon indicating copy to clipboard operation
docs copied to clipboard

refactor: Merge vanilla default files with normal config files

Open Leguan16 opened this issue 1 year ago • 1 comments

I do not like the current solution to the "how-to vanilla" page. Thats why I am proposing a refactor that merges the two files with adding a vanilla field to config options that alter the vanilla behavior.

only-merge-items-horizontally:
  vanilla: "true"
  default: "false"
  description: >-
    Prevents merging items that are not on the same y level, preventing potential
    visual artifacts.

I am aware of the unnecessary nodes showing no default value. Unfortunately, I did not yet find a way to get rid of them without major refactoring of already existing code. If you have suggestions, please share!

Leguan16 avatar Aug 13 '24 01:08 Leguan16

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview eab7632e815c2d2a96cf4247d68c6d43fc15d4b1

github-actions[bot] avatar Aug 13 '24 01:08 github-actions[bot]

should be open for reviews now!

Leguan16 avatar Jan 03 '25 16:01 Leguan16

Alright will do! I also like it way more than the current version.

Leguan16 avatar Jan 14 '25 15:01 Leguan16

I like this implementation a lot more, thanks! One thing, could you please rename this vanilla within the ConfigDocBlock to something more like showVanillaValue or something slightly more self explanatory. Good to merge then

changed the param name.

Leguan16 avatar Jan 14 '25 19:01 Leguan16