Waterfall icon indicating copy to clipboard operation
Waterfall copied to clipboard

Add root/admin user warning

Open NoahvdAa opened this issue 4 years ago • 3 comments

This PR ports the root detection introduced in PaperMC/Paper#2432 (and re-added in PaperMC/Paper#6593) to Waterfall. The implementation used in PaperMC/Paper#6593 doesn't seem to work on Java 8, so I've used a slightly different check.

Tested on macOS and Windows 10.

NoahvdAa avatar Sep 30 '21 16:09 NoahvdAa

This PR ports the root detection introduced in PaperMC/Paper#2432 (and re-added in PaperMC/Paper#6593) to Waterfall. The implementation used in PaperMC/Paper#6593 doesn't seem to work on Java 8, so I've used a slightly different check.

Tested on macOS and Windows 10.

I think this is useless, since most people don't have access to SSH, and those who do have access already have some experience, it seems to me that adding a warning for that is redundant.

xism4 avatar Feb 01 '23 23:02 xism4

This PR ports the root detection introduced in PaperMC/Paper#2432 (and re-added in PaperMC/Paper#6593) to Waterfall. The implementation used in PaperMC/Paper#6593 doesn't seem to work on Java 8, so I've used a slightly different check. Tested on macOS and Windows 10.

I think this is useless, since most people don't have access to SSH, and those who do have access already have some experience, it seems to me that adding a warning for that is redundant.

It is not redundant. I believe many people running a server network do have a vserver/vps or root server rented, because they're often cheaper compared to multiple single mc servers.

Janmm14 avatar Feb 02 '23 11:02 Janmm14

I dont like the way you doing it i would use io.netty.util.internal.PlatformDependent#maybeSuperUser() instead if your reg check and creating processes, this should be enought

Outfluencer avatar Feb 23 '24 16:02 Outfluencer