Waterfall icon indicating copy to clipboard operation
Waterfall copied to clipboard

Reset max health attribute on server switch

Open kennytv opened this issue 5 years ago • 2 comments

Attributes aren't reset, so the player sees the wrong amount of hearts when switching away from a server that changed the default value to a server without the change (since default attributes are not sent to the client). All of the other attributes either don't affect the client itself or are reset due to non-default values for players, so only the max health attribute is important.

kennytv avatar Jun 06 '20 18:06 kennytv

While we are on this subject, shouldn't JoinGame be resent if the next server is != the same mode (hardcore or not hardcore) ?

Xernium avatar Jun 28 '20 10:06 Xernium

While we are on this subject, shouldn't JoinGame be resent if the next server is != the same mode (hardcore or not hardcore) ? @Xernium

This is already done if you enable the option "disableEntityMetadataRewrite" in Waterfall.

It should also be checked if that does reset the client's max health, in that caser this patch would need additional ifs so we don't send it if its not actually needed.

Janmm14 avatar Nov 03 '20 23:11 Janmm14