Proper support and integration for Chat registry

[JustEli]

Messages sent to chat by (my) plugins in Velocity, using kyori, get prefixed with '<> ', eversince 1.19. The following code was used:

TextComponent.Builder component =
  Component.text()
    .append(Component.text(part1))
    .append(Component.text(part2));

this.proxy.getAllPlayers().forEach(player -> player.sendMessage(component));

This did not happen pre-1.19. It also does not happen for any message sent from a Paper server.

Velocity 3.1.2-SNAPSHOT (git-74edac96-b153)

[electronicboy]

if viaversion, update to latest dev build

[JustEli]

ViaVersion is not installed NuVotifier, LiteBans and LuckPerms are

[Xernium]

The reason this happens is because the current version of Velocity can‘t be aware of the ID from the chat-registry it should be using. This will be fixed in the near future.

[JustEli]

thank you

[JustEli]

any updates on this?

[electronicboy]

Work is currently on a branch, the <> should of been fixed this morning, however

[davidmayr]

Work is currently on a branch, the <> should of been fixed this morning, however

Just updated to the Branch dev/chat-registry (compiled it myself) and I still get them. On the Backend Servers I run the current Release of ViaVersion and not a Dev-Build though. Maybe that's the issue?

I'm just not Upgrading because of this issue: ViaVersion/ViaVersion#2945

[electronicboy]

Yea, via is going to induce that issue as they send an unexpected registry which causes an id mismatch, that should be fixed in their dev builds

[davidmayr]

Yea, via is going to induce that issue as they send an unexpected registry which causes an id mismatch, that should be fixed in their dev builds

But it's not. Using the newest ViaVersion Dev-Build(https://ci.viaversion.com/job/ViaVersion-DEV/712/) you will receive messages that were sent before you joined a server with the <> in front of the text but not any messages after that. This build makes all Velocity messages disappear. (As mentioned in the issue I linked)

[electronicboy]

I cannot reproduce this issue on the main dev builds, the chat registry stuff is still a work in progress and missing some steps to handle some cases

DO note that when I said fixed this morning, I meant my commit in the snapshot branch, not the chat registry branch, I've not handled the servers chat packet yet to actually use the registry, and not sure if I committed 100% of my stuff on the registry branch yet

[JustEli]

it is fixed for my server, thanks

[davidmayr]

Yeah, that fixed it. And after updating ViaVersion to its dev build, it's working without any problems.