Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Brand payload packets don't work

Open ThrowerWay opened this issue 2 years ago • 4 comments

Expected behavior

Client brand packets should contain their brand.

Observed/Actual behavior

After recently updating paper, it seems like somehow brand packets are deserialized wrongly to have unknown brand payloads instead of net.minecraft.network.protocol.common.custom.BrandPayload, the result is that the .data() is an empty string instead of the client brand.

Steps/models to reproduce

Listen for payload packets

Plugin and Datapack List

Protocollib (for listening to the packets), i am just calling .getHandle() to get the raw NMS packet though

Paper version

This server is running Paper version git-Paper-"1865625" (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 1865625) You are 3 version(s) behind Download the new version at: https://papermc.io/downloads/paper Previous version: git-Paper-"4b0bc74" (MC: 1.20.2)

Other

No response

ThrowerWay avatar Nov 03 '23 17:11 ThrowerWay

Yeah, upstream just decided to remove the custom handling and handle everything as unknown.

Machine-Maker avatar Nov 03 '23 17:11 Machine-Maker

Yeah, upstream just decided to remove the custom handling and handle everything as unknown.

Damn, what can be done to fix this?

My current workarodund is player.getClientBrandName()

ghost avatar Nov 03 '23 17:11 ghost

There is #9863 as a possible approach to solve this issue

Sytm avatar Nov 03 '23 17:11 Sytm

oh yeah, isn't the entire on plugin message received thing broken?

ghost avatar Nov 03 '23 17:11 ghost