Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Published 20 hours ago • verified publisher icon PaperMC

Fix MC-255756

Open roro1506HD opened this issue 1 year ago • 2 comments

This PR fixes shields not playing sounds when being broken by an axe or when blocking a damage. This bug is client-sided but can easily be fixed by playing the sounds instead of the entity events, this is exactly what this PR does.

roro1506HD avatar Aug 25 '23 12:08 roro1506HD

Maybe it would be better to both broadcast the entity event and play the sound?

imDaniX avatar Aug 25 '23 13:08 imDaniX

Maybe it would be better to both broadcast the entity event and play the sound?

I chose not to send both because when mojang is gonna fix the issue on their end, we're gonna have a time where the sound is gonna be played twice

roro1506HD avatar Aug 25 '23 14:08 roro1506HD