Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Add sniffer egg api

Open Lulu13022002 opened this issue 2 years ago • 2 comments

Call the BlockGrowEvent and BlockFadeEvent during hatch process for the sniffer eggs Add the Egg spawn reason for the new baby sniffer

Lulu13022002 avatar Jun 09 '23 14:06 Lulu13022002

You're right i have updated the patch, i need to reschedule the tick manually otherwise the particles/game event will shown when cancelled

Lulu13022002 avatar Jun 09 '23 20:06 Lulu13022002

I would move the already existing diff to a separate method.

Owen1212055 avatar Jun 09 '23 21:06 Owen1212055

It would be nice to be able to configure the hatch time in general (int baseDelay = hatchBoost(world, pos) ? 12000 : 24000;) either via an event or via the world configuration

Summerfeeling avatar Jun 20 '23 20:06 Summerfeeling

I don't really want an event that specific, now that the grow/fade are called anyway but i'm okay with a world config if you have some idea of its name/section in the file feel free. In fact i have modified those to test the events (because otherwise it's way too long) so i can understand the need.

Lulu13022002 avatar Jun 22 '23 10:06 Lulu13022002

Maybe something like entities.sniffer.hatch-time and entities.sniffer.boosted-hatch-time? It would also be cool if you could reduce the eight minute cooldown after sniffing out a seed (entities.sniffer.dig-cooldown?)

Summerfeeling avatar Jun 25 '23 14:06 Summerfeeling

I have added the config option, i will not allow to change the sniffer cooldown since this is done using the memory key. Sadly spigot doesn't cover this key yet but you can look at this pr: https://github.com/PaperMC/Paper/pull/5605/files#diff-95136ad09028dbf026de8d80d4a480d7a98c3cafa77dfc0f00b939654e20e916R181 and you can't change the expiration of a memory key yet.

Lulu13022002 avatar Jun 27 '23 11:06 Lulu13022002

Thanks a lot! I really appreciate your efforts

Summerfeeling avatar Jun 27 '23 22:06 Summerfeeling