Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Added boolean hideInPlayerList to hidePlayer function.

Open JMBoy01 opened this issue 1 year ago • 2 comments

#9045 Made changes to the hidePlayer function. You can chose if the player also disappears from the player list.

JMBoy01 avatar May 26 '23 18:05 JMBoy01

Presumably a partial duplicate of #8782, at least in what it aims to achive.

//edit Welcome to paper and thanks for your first PR :)

lynxplay avatar May 26 '23 18:05 lynxplay

Presumably a partial duplicate of #8782, at least in what it aims to achive.

//edit Welcome to paper and thanks for your first PR :)

I think it is good add-on to the pr you mentioned. There is no way on said PR to hide player while retaining them in player list. You need to hide player and then reshow them in the list. This will allow to do it in one step.

But it would be good to coordinate these to prs so there are not conflicts...

dawon avatar May 26 '23 18:05 dawon

Hello, is it normal that I'm still waiting on a review or isn't that going to happen since 1.20 came out in the mean time? I would just like to know.

JMBoy01 avatar Jul 03 '23 11:07 JMBoy01

Hello, is it normal that I'm still waiting on a review or isn't that going to happen since 1.20 came out in the mean time? I would just like to know.

image

kforbro avatar Jul 05 '23 22:07 kforbro

Closing this as a duplicate of #8782. Thank you for your contributions.

underscore11code avatar Aug 20 '23 08:08 underscore11code