Paper
Paper copied to clipboard
PaperMC
add config for velocity secret key file
Adds a proxies.velocity.secret-file option, making it possible to specify a file containing the velocity secret file instead of including it in the yml. Similarly to https://github.com/PaperMC/Velocity/pull/712.
Should work nicely, here's a couple of questions:
- Should I bump the config version to 29?
- Should we somehow deprecate the previous option? For now, I've added a log warning for it.
Fixes https://github.com/PaperMC/Paper/issues/6332
You should edit the patch adding Velocity support rather than adding a new one.
And config file stuff should stay in the config patch
If we're going to force people to move over, we should be handling that as a migration, but, I'm not sure we should force people to use an external file
On Mon, 2 Jan 2023, 21:40 _tomcraft, @.***> wrote:
You should edit the patch adding Velocity support rather than adding a new one.
— Reply to this email directly, view it on GitHub https://github.com/PaperMC/Paper/pull/8755#issuecomment-1369228290, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMAZFU6XH3DT6GWTWD5MLWQNDMTANCNFSM6AAAAAATPDTIWU . You are receiving this because your review was requested.Message ID: @.***>
If we're going to force people to move over, we should be handling that as a migration, but, I'm not sure we should force people to use an external file
Velocity does generate one by default, though. So probably it would be a better user experience to match it. But keep both should work too.
You should edit the patch adding Velocity support rather than adding a new one.
And config file stuff should stay in the config patch
Gotcha!
