Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Chest minecarts are no longer affected by re-looting options.

Open flanigomik opened this issue 3 years ago • 1 comments
trafficstars

Expected behavior

Chest minecarts found in mine shafts are restocked with loot like all other loot chests

Observed/Actual behavior

as of 1.19 chest minecarts are excluded from loot re-rolls

Steps/models to reproduce

set up chest-relooting locate chest minecart loot minecart allow specified time to pass no loot

Plugin and Datapack List

issue occurs in out of box setups, but here is my list

plugins [19:21:12 INFO]: Plugins (32): AntiCreeper, AntiEndermanGrief, Chunky, CMI, CMILib, ConsoleSpamFix, CoreProtect, DiscordSRV, dynmap, Graves, InventoryRollbackPlus, LastLoginAPI, LibsDisguises, LuckPerms, MarriageMaster, OpenInv, OreAnnouncer, Plan, PlayerParticles, PlugManX (PlugMan), ProCosmetics, ProtocolLib, ShopGUIPlus, StaffPlusPlus, UltimateAutoRestart, Vault, VaultChatFormatter, voicechat, Votifier, VotingPlugin, WorldEdit, WorldGuard

datapack list [19:21:16 INFO]: There are 17 data packs enabled: [vanilla (built-in)], [file/bukkit (world)], [file/armor statues v2.8.4.zip (world)], [file/custom nether portals v2.3.6.zip (world)], [file/double shulker shells v1.3.3.zip (world)], [file/fast leaf decay v2.0.6.zip (world)], [file/more mob heads v2.10.1.zip (world)], [file/nether portal coords v1.1.3.zip (world)], [file/player head drops v1.1.3.zip (world)], [file/silence mobs v1.1.3.zip (world)], [file/spawning spheres v1.1.3.zip (world)], [file/tag v2.1.3.zip (world)], [file/villager workstation highlights v1.1.3.zip (world)], [file/wandering trades hermit edition v1.7.0.zip (world)], [file/VanillaTweaks_c725925.zip (world)], [file/coordinates hud v1.2.3.zip (world)], [file/BlazeandCaves Advancements Pack 1.15.zip (world)]

Paper version

paper version [19:21:55 INFO]: Checking version, please wait... [19:21:56 INFO]: This server is running Paper version git-Paper-265 (MC: 1.19.2) (Implementing API version 1.19.2-R0.1-SNAPSHOT) (Git: 117579c) You are 5 version(s) behind Download the new version at: https://papermc.io/downloads Previous version: git-Paper-220 (MC: 1.19.2)

Other

this seems to only affect chest minecarts, all other chests (as far as i know) are working as intended.

flanigomik avatar Nov 14 '22 00:11 flanigomik

See ContainerEntity#unpackChestVehicleLootTable and RandomizableContainerBlockEntity#unpackLootTable

Paper adds some logic to the block entity method, but not the entity one. Whoever wants to tackle this, feel free!

Owen1212055 avatar Nov 14 '22 23:11 Owen1212055