Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Handle properly the custom bukkit damage cause

Open Lulu13022002 opened this issue 3 years ago • 0 comments

The custom bukkit damage cause MELTING and POISON replace totally the vanilla ones resulting in incompatible vanilla behavior and a non future proof way. For example in vanilla when you throw a potion of poison on a silverfish near stone/infested brick it will destroy the nearby stones, but on paper it doesn't because of the custom poison replacing the magic one (so source == DamageSource.MAGIC become false). Also i know that the shallow clone that bukkit does isn't future proof but since the DamageCause will be deprecated it's not really a problem actually.

Lulu13022002 avatar Nov 01 '22 14:11 Lulu13022002