Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Adding config to allow marker ticking (#8118)

Open piratecody opened this issue 3 years ago • 2 comments

This adds a world config option to allow markers to be ticked, rather than just having them not ticked at all. Defaults to false so the existing functionality is the same for those that don't need markers to tick.

piratecody avatar Sep 18 '22 23:09 piratecody

I would edit the patch that adds this functionality instead of making a new patch.

Owen1212055 avatar Sep 18 '22 23:09 Owen1212055

Hi :wave: congrats on your first paper PR!

As owen already pointed out, to reduce patches in general, the logic should live in the patch that originally introduced the marker-no-tick (https://github.com/PaperMC/Paper/blob/master/patches/server/0891-Don-t-tick-markers.patch).

Beyond that, changes the any of the configuration files belong in the https://github.com/PaperMC/Paper/blob/master/patches/server/0004-Paper-config-files.patch patch. If you have any specific questions on how to achieve this, feel free to ask in our #paper-dev channel on the paper discord :)

lynxplay avatar Sep 18 '22 23:09 lynxplay