Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Fix set profile patch issues

Open Owen1212055 opened this issue 3 years ago • 1 comments

The old setPlayerProfile would cause a duplicate player to appear in tab list because the previous game profile was not removed properly. This caused it to not work at all.

This also moves a bunch of the deprecation patches to the correct patch. However, it might be better to merge those patches together (merger plz).

Owen1212055 avatar Aug 14 '22 18:08 Owen1212055

Theses two patch (https://github.com/PaperMC/Paper/blob/master/patches/api/0175-Entity-getEntitySpawnReason.patch and https://github.com/PaperMC/Paper/blob/master/patches/api/0226-Clarify-the-Javadocs-for-Entity.getEntitySpawnReason.patch) should be also merge i think

Lulu13022002 avatar Aug 15 '22 15:08 Lulu13022002

Please split the fix and patch switcheroos into different prs, or at least different commits, also with more comments on what changed and why; as is this is unreviewable

kennytv avatar Oct 01 '22 09:10 kennytv

Yeah, i'll close this and open new ones when I get to it.

Owen1212055 avatar Oct 01 '22 16:10 Owen1212055