Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Add configuration option for MiniMessage-formatted MOTD

Open wordandahalf opened this issue 3 years ago • 4 comments
trafficstars

This closes #8230 by adding a new configuration option at messages.motd in paper-global.yml that overrides the value of motd in server.properties if it exists.

This is my first contribution, so please let me know if there is anything that I can change; I feel like there may have been some curfuffling in the process of rebuilding of the patches, but it functioned as expected when I tested.

Thanks!

wordandahalf avatar Aug 05 '22 03:08 wordandahalf

Welcome to the world of PR :3 For config things you need add to the patch related to config like mention the contribution files https://github.com/PaperMC/Paper/blob/master/CONTRIBUTING.md#committing-changes and then make another patch for your changes (if im not wrong...)

Doc94 avatar Aug 05 '22 03:08 Doc94

For config things you need add to the patch related to config like mention the contribution files https://github.com/PaperMC/Paper/blob/master/CONTRIBUTING.md#committing-changes and then make another patch for your changes (if im not wrong...)

Thanks for that, I managed to miss that tidbit.

wordandahalf avatar Aug 05 '22 03:08 wordandahalf

I've (hopefully) fixed up the configuration commit. I've noticed that my patch numbers do not correspond with the existing numbering. Is that an issue?

wordandahalf avatar Aug 08 '22 01:08 wordandahalf

This can be fixed by applying patches and rebuilding.

In general, I see why the whole "null" is a little bit iffy. What if we had a new type that represented an "override"? Basically, if motd was equal to unset this would cause it to use the default vanilla server properties.

This might be a useful type in general if we want to move more things to use adventure like this.

Owen1212055 avatar Nov 26 '22 17:11 Owen1212055