Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Add MaterialTags for the different Types of Tools

Open thelooter opened this issue 3 years ago • 7 comments

Adds MaterialTags for the following Types of Tools:

  • Wooden Tools
  • Stone Tools
  • Iron Tools
  • Gold Tools
  • Diamond Tools
  • Netherite Tools

thelooter avatar Jun 25 '22 19:06 thelooter

Just by tags names, it's actually a bit unclear what's included into those - we also have items like shears, flint'n'steel, clock and compass, bucket.

imDaniX avatar Jun 25 '22 20:06 imDaniX

What Names would you suggest instead?

thelooter avatar Jun 25 '22 20:06 thelooter

I disagree in the names being unclear. I feel the sheers, flint n steel, click, compass and bucket fit into their own category independent of the main tiered tools.

cody-quinn avatar Jun 25 '22 21:06 cody-quinn

I disagree in the names being unclear. I feel the sheers, flint n steel, click, compass and bucket fit into their own category independent of the main tiered tools.

I mean, while bucket, compass and clock don't really fit there, shears and flint'n'steel absolutely do - both are indeed tools, made using iron, both do have durability and can be enchanted. If we don't include these in iron tools, at least is should be noted in javadocs.

imDaniX avatar Jun 25 '22 21:06 imDaniX

I disagree in the names being unclear. I feel the sheers, flint n steel, click, compass and bucket fit into their own category independent of the main tiered tools.

I mean, while bucket, compass and clock don't really fit there, shears and flint'n'steel absolutely do - both are indeed tools, made using iron, both do have durability and can be enchanted. If we don't include these in iron tools, at least is should be noted in javadocs.

I can agree with the information about them being exlucded should be included in the JavaDocs. However I still don't think they should be included in the collection itself as they are not tiered. The naming of wooden, iron, exc. makes me assume the collections are refering to the tiered tools where diamond will include all the diamond equivalents of the iron tools.

Maybe an UNTIERED_TOOLS or OTHER_TOOLS collection could be made for those?

cody-quinn avatar Jun 25 '22 21:06 cody-quinn

In the future, I recommend creating PRS on other branches (not your master branch, because it makes some things difficult)

Looks good tho

Yeah I usually do. Only noticed I was on master after opening the PR.

thelooter avatar Jul 21 '22 04:07 thelooter

Any update on this?

thelooter avatar Sep 28 '22 22:09 thelooter