Allow customizing hopper minecart cooldowns

[Owen1212055]

Currently, hopper minecarts ignore the cooldown completely, as they never update the last position variable. (It only follows the cooldown if the hopper minecart is at 0,0,0) Mojang has this issue marked as Works as Intended.

Therefore, I decided to fix this by not using this system and instead just correctly respecting when the cooldown is set. This is because paper sets the cooldown in some places, and I feel it's appropriate to have those applied to these hoppers as well. This should ensure that the optimizations to hoppers properly have cooldowns applied to hopper minecarts (for example, if the hopper is full).

Another fix is to possibly just update the lastPosition, however, this will cause the optimization to perhaps skip the cooldown in some cases if the hopper minecart moves, which seems a bit silly, especially since this system isn't even used.

Feedback is needed on this if this should be the correct fix, a separate config to change the cooldown on minecart hoppers (currently the normal cooldown of hoppers / 2), or if we just fix the vanilla system.

Also, should this go in a separate patch? Or the optimized hopper patch?

[Owen1212055]

Added hopperMinecartTransferCooldown + resetHopperMinecartCooldownOnMove to the paperconfig.

hopperMinecartTransferCooldown will now control the cooldown that is applied, which because of the fact that this has been non-functional has been set to 0 in order to prevent any breaking of mob farm contraptions.

resetHopperMinecartCooldownOnMove determines if the cooldown should be reset if the hopper moves blocks. This by default is true, as this is vanilla behavior (that doesn't correctly function).

This in the end causes this to have no change unless configured.

[electronicboy]

I've posted on the issue, and asked privately, about the "WAI" status of that issue but not heard back, makes very little sense...

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.

[Owen1212055]

Rebased

[Owen1212055]

This logic no longer exists in vanilla