Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Fix crafting in custom inventories

Open Machine-Maker opened this issue 2 years ago • 4 comments

This uses some pretty absurd solutions I think to fix some existing issues with bukkit's inventory system and inventories created vis Bukkit.createInventory(). I recommend people use the HumanEntity#openSomething methods cause those are going to be pretty good, but they don't afford as much customization as the other ones.

Creating this as a draft because I haven't tested all the inventories and I'm sure others suffer from the same problem anvil, smithing tables, and enchant tables did. It's mainly non-tile-entity crafting block inventories, so I think looms, stonecutters, and grindstones are probably affected.

Fixes https://github.com/PaperMC/Paper/issues/10621

Fixed

  • [x] Enchanting
  • [x] Anvil
  • [x] Smithing
  • [ ] Beacon
  • [x] Loom
  • [ ] Cartography
  • [ ] Grindstone
  • [x] Stonecutter

Machine-Maker avatar Jan 03 '22 06:01 Machine-Maker

Now includes fixes for Looms and Stonecutters. Also fixes https://github.com/PaperMC/Paper/issues/5825 now.

Machine-Maker avatar Jan 13 '22 06:01 Machine-Maker

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 15 '22 00:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 24 '22 01:06 stale[bot]

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.

stale[bot] avatar Jul 02 '22 00:07 stale[bot]