Paper Add api for getting direct entity cause of knockback

Closes https://github.com/PaperMC/Paper/issues/7168

Dec 21 '21 21:12 Machine-Maker

When is this and #7171 getting merged?

Jan 30 '22 13:01 vytskalt

I'm not entierly happy that EntityKnockbackByEntityEvent#getDirectHitBy() is nullable when it'll only be null if the legacy ctor is used. What if that return value was wrapped in a requireNonNull call? Cause it really should be notnull.

Feb 03 '22 19:02 Machine-Maker

I'm not entierly happy that EntityKnockbackByEntityEvent#getDirectHitBy() is nullable when it'll only be null if the legacy ctor is used. What if that return value was wrapped in a requireNonNull call? Cause it really should be notnull.

Yes, I think its better to do that instead of keeping it nullable

Feb 04 '22 11:02 vytskalt

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Apr 06 '22 17:04 stale[bot]

Still need this.

Apr 08 '22 07:04 vytskalt

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Jun 10 '22 17:06 stale[bot]

no

Jun 10 '22 17:06 vytskalt

Is it worth to wait for https://github.com/PaperMC/Paper/pull/8058 and pass directly the damage source here and also for the PushEvent (another PR) ?

Jul 21 '22 10:07 Lulu13022002

Hi, is there anything I can do to help this PR get merged at some point? It's been 2 years and I still need this API...

Mar 27 '24 15:03 vytskalt

I think we may be better of deprecating the existing method and choosing some more descriptive names for this 👍

Jul 27 '24 15:07 lynxplay