Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Add API to get if an entity can be sheared/simulate being sheared.

Open Owen1212055 opened this issue 4 years ago • 11 comments
trafficstars

Not sure if the source is needed in the method, but I thought it might be neat to include.

Owen1212055 avatar Oct 17 '21 20:10 Owen1212055

Ignore the references :sweat_smile: I typo-ed the "Resolves" link from 6797 to 6796.

lynxplay avatar Oct 17 '21 23:10 lynxplay

Also rebased

Owen1212055 avatar Oct 21 '21 20:10 Owen1212055

Clarified the javadocs a bit, hopefully, it makes more sense now.

Owen1212055 avatar Nov 13 '21 20:11 Owen1212055

Some entities also implement an interface called Bucketable, which could allow us to add some methods such as being able to get the item produced when bucketing it, or forcing it to be bucketed too. image image

This is somewhat similar to this PR, in that it just exposes an interface that certain entities can implement. Should I make this PR a bit more "generic" to "Expose Vanilla Entity Interfaces" or something?

So I am proposing I add the Bucketable interface to this PR as well.

Owen1212055 avatar Dec 12 '21 16:12 Owen1212055

Rebased and made provided changes.

Owen1212055 avatar Dec 26 '21 18:12 Owen1212055

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 25 '22 01:02 stale[bot]

Still around

Owen1212055 avatar Feb 25 '22 13:02 Owen1212055

Something that should at least be documented to some extent is that the entity may no longer be valid after shearing, such as in the case of a Mooshroom, it will be replaced by a new entity.

Also, do we care about calling the shear events and returning a boolean? Interested what others think on both these concerns.

jpenilla avatar Mar 03 '22 21:03 jpenilla

Something that should at least be documented to some extent is that the entity may no longer be valid after shearing, such as in the case of a Mooshroom, it will be replaced by a new entity.

Also, do we care about calling the shear events and returning a boolean? Interested what others think on both these concerns.

Personally I think that the event here can still be followed, as it's supposed to simulate as if it were sheared by a player/source. But yea, i'd wonder what other swould think to.

And yep, documented & rebased!

Owen1212055 avatar Mar 04 '22 23:03 Owen1212055

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 04 '22 21:05 stale[bot]

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.

stale[bot] avatar Jun 04 '22 01:06 stale[bot]