Add CompostItemEvent and EntityCompostItemEvent

[NoahvdAa]

Adds #6349 . The event exposes the player who composted, the composter block, the item stack used, whether or not the level will be raised (settable), the level the composter currently has and it is of course cancellable.

[Machine-Maker]

This really seems like too much diff in the server patch for something so simple. Hold off on merging for now

[Machine-Maker]

Also, I feel like this event should not be player-specific, cause villagers also compost stuff, and hoppers can insert items as well.

[NoahvdAa]

I've just pushed a commit that renames the event to CompostItemEvent (based on MachineMaker's implementation), which can now be triggered by entities (villagers/players) and hoppers.

[NoahvdAa]

I've now added a parent event, CompostItemEvent. Right now it only fires when an item is composted by a hopper, and the EntityCompostItemEvent, as the name implies, only fires when an entity composts an item. Should the parent event be fired aswell whenever the EntityCompostItemEvent is fired, or is the current implementation fine?

[Machine-Maker]

(see https://github.com/PaperMC/Paper/pull/6356#discussion_r685663260)

[Machine-Maker]

(These things can be handled by the merger so not really "required changes now")

[NoahvdAa]

Now that I think of it, these events should probably be in the io.papermc.paper.event package instead of com.destroystokyo.paper.event, right?

[JRoy]

Now that I think of it, these events should probably be in the io.papermc.paper.event package instead of com.destroystokyo.paper.event, right?

Yes

[NoahvdAa]

Rebased, comments have also been addressed.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[NoahvdAa]

Rebased for 1.18.2

[NoahvdAa]

Rebased and re-tested, on this PRs birthday 🥳




~~let's hope it doesn't have a second~~