Itemstack Glint API

[Machine-Maker]

Closes #5274

First time touching item meta stuff

Unsure of a few things, mainly the behavior of this elsewhere in the codebase, like anvils/grindstones. Currently you can remove the glint with the grindstone (and get no xp), and you can put enchanted books on the item, BUT that removes the empty NBTTagCompound, so removing that enchant will make the item lose it's glint.

Issue relating to this: #5723

[JRoy]

Not sure how I feel about this because all this seems like is a helper method for adding enchantments while making it seem like an inherent property an ItemStack can have.

Also, has this been tested with items that already have enchantments on them?

[Machine-Maker]

I didn’t specifically test that JRoy, but the result would be an Enchantments nbt list with a normal tagcompound and an empty one. I don’t see how that would behave differently from a list with just an empty one

[Machine-Maker]

Won't that still show up on the item? I dont know how the client determines what shows up or not if its missing an equivalent on the client side.

[kennytv]

You can easily create "invisible" enchantments, even with API (with no hide tag required).

[kennytv]

Aside from Bukkit, the most basic format a client accepts perfectly fine is something along the lines of this (just some Via code stuffed somewhere to get the gist of it):

            // Add dummy enchant for the glow effect if there are no actual enchantments left
            if (!storedEnchant && enchantments.size() == 0) {
                CompoundTag dummyEnchantment = new CompoundTag();
                dummyEnchantment.put("id", new StringTag()); // String value empty = ""
                dummyEnchantment.put("lvl", new ShortTag((short) 0));
                enchantments.add(dummyEnchantment);
            }

[HexedHero]

Curious, how does normal items have the enchantment glint without any enchantments such as the golden apple?

[Machine-Maker]

Pretty sure those are hardcoded by on the client.

[Owen1212055]

(yarn mappings)

[Machine-Maker]

(yarn mappings)

Yes, exactly, I don’t think that is ever passed between the client and server, hence, hardcoded.

[HexedHero]

Can we just ask Mojang for an NBT flag it seems super easy.

[electronicboy]

I've dropped that suggestion in a place where we often speak to mojang devs, will see if they have any comments on this as the general handling of this always feels a bit icky, so I'd love to avoid having to do something like this as supported API

[nicolasvac]

@electronicboy Do you have any news on it ?

[Owen1212055]

In general, this can prolly be closed? Hopefully waiting on mojang for this, but with my item property API these types of items will work just fine in the future due to no item meta processing being done.

[Owen1212055]

Closing in favor of the item property api.

[lowercasebtw]

in 1.20.5, we will be getting components, and one is override_enchantment_glint