Paper icon indicating copy to clipboard operation
Paper copied to clipboard

feat: Add new overloads for Pathfinder

Open Toffikk opened this issue 2 months ago • 7 comments

Fixes #13191

Toffikk avatar Oct 16 '25 15:10 Toffikk

Not really a fan of deprecating the existing method, wouldn't that require everyone to cast to Entity to not get the deprecation warning? The existing method could also become a default and call the new one.

Warriorrrr avatar Oct 16 '25 15:10 Warriorrrr

Not really a fan of deprecating the existing method, wouldn't that require everyone to cast to Entity to not get the deprecation warning? The existing method could also become a default and call the new one.

I get the point but i deprecated it because LivingEntity is extending Entity so we shouldn't keep an overload that's basically going to do the same thing as the other one but more limited, the best solution would be to remove the old one but that would cause all plugins to need to be recompiled. The devs can choose to either suppress that warning in some way or just wait until the old one gets removed and update their dependency on paper-api and everything will work fine, no matter if they start casting to Entity now or leave their code as it is

Toffikk avatar Oct 16 '25 16:10 Toffikk

We could perhaps add an @apiNote with a notice that their plugins might require a recompile on the next version and a link to the new overloads

Toffikk avatar Oct 16 '25 16:10 Toffikk

so we shouldn't keep an overload that's basically going to do the same thing as the other one but more limited

I don't see why not, it's not like that default LivingEntity method would ever require maintenance when it's just redirecting to the Entity method

We could perhaps add an @apiNote with a notice that their plugins might require a recompile on the next version and a link to the new overloads

Sounds extremely awful

masmc05 avatar Oct 16 '25 16:10 masmc05

so we shouldn't keep an overload that's basically going to do the same thing as the other one but more limited

I don't see why not, it's not like that default LivingEntity method would ever require maintenance when it's just redirecting to the Entity method

I'll change that then to redirect to the new one

Toffikk avatar Oct 16 '25 16:10 Toffikk

done, now the LivingEntity overloads just redirect to the Entity ones

Toffikk avatar Oct 16 '25 16:10 Toffikk

@Lulu13022002 everything should be addressed now👍 I left the repeated to removal tho

Toffikk avatar Oct 27 '25 17:10 Toffikk