Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Add Waypoint Styling API

Open Y2Kwastaken opened this issue 5 months ago • 5 comments

This PR adds a waypoint styling api to LivingEntity to allow for the editing of the waypoint style.

Y2Kwastaken avatar Aug 11 '25 13:08 Y2Kwastaken

i was working in this but i think was too slow xd a few comments based in my try...

  • i think can be better add a interface for waypoint where the methods exists and use that in the LivingEntity (and in that use a WaypointIcon)
  • Maybe can be good use ClientTextureAsset for the asset?
  • The waypoint manager can be good also expose for make thing like get current waypoints and manage in that a show/hide

Doc94 avatar Aug 11 '25 13:08 Doc94

think can be better add a interface for waypoint

I was also thinking about this and 100% agree, but I wasn't sure if that's what was being "looked for" per se I def want to wait for a maintainer on that one. This would also allow for something like an "editStyle" method for bulk changes so you don't have to track and untrack all players twice to update both.

Maybe can be good use ClientTextureAsset for the asset?

I didn't even know about this one lol. Yeah definitely seems like the right choice for this API

The waypoint manager can be good also expose for make thing like get current waypoints and manage in that a show/hide

I'll definitely look into that one

Y2Kwastaken avatar Aug 11 '25 14:08 Y2Kwastaken

ok well I was going to look into the other suggestions but my IJ broke so; whether we need a separate interface, since I don't know what can have or can be a waypoint. General waypoint management beyond that can be done later if wanted

kennytv avatar Aug 29 '25 16:08 kennytv

please complete this.

maximjsx avatar Sep 19 '25 10:09 maximjsx

please complete this.

its in a party pr, which probably means it gonna get pushed with other prs together when they als are finished. image

illyrius666 avatar Sep 20 '25 08:09 illyrius666