PaperMC
Allow Changing Crafting Remainders
- added a method and field to CraftItemEvent
- made them used in ResultSlot
- ServerGamePacketListenerImpl, the class calling CraftItemEvent, sets ResultSlot's static list
You also seem to have made your NMS changes a feature patch. The changes you introduced there are more fitting to be added as a file patch. Please change that
This is a bit of an invasive change, with requiring the resultslot change looking very hacky. The only reason I am a little iffy about introducing api here is that it possibly looks like this may be reworked a bit in the future.
craftingRemainingItem is one of the last manually defined fields that aren't backed by components anymore, which is indicative to me that this may be on some kind of future cleanup list on Mojang's end. Issue is obviously overriding the leftovers like this is a bit tricky with what is currently given api wise.
I've implemented it in this way because I didn't want to change up how and where the Event is called. Hence the hacky field in ResultSlot. If there's a better way, please say so.
Of course Mojang will make this change pretty much obsolete in the future, but when that happens this change can either be reverted or adjusted depending on how they do it.
There also may be some workaround by cancelling or setting the Result of the CraftItemEvent, but then a developer would need to implement ResultSlot's code themselves.