Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Add PlayerAttackEntityEvent

Open TransparentWhit opened this issue 8 months ago • 2 comments

Improved from #12319

TransparentWhit avatar Apr 06 '25 15:04 TransparentWhit

I am not sure whether the knockback should be part of the enum. IMO you can crit & knockback and sweep & knockback... Maybe a separate boolean?

dawon avatar Apr 08 '25 06:04 dawon

I am not sure whether the knockback should be part of the enum. IMO you can crit & knockback and sweep & knockback... Maybe a separate boolean?

In vanilla, a kb attack requires the player to be sprinting, and crit/sweep requires that the player is not sprinting. However, when you do a kb attack, unlike crit/sweep, the normal attack sound effect is also played so I'm not really sure what vanilla is doing here (or what it's intending to do) but it kinda suggests the possibility. Also kb attacks don't involve extra particles or anything so it wouldn't be hard to implement.

TransparentWhit avatar Apr 08 '25 10:04 TransparentWhit