Paper icon indicating copy to clipboard operation
Paper copied to clipboard
verified publisher icon PaperMC

add ItemFrameMeta API

Open TehBrian opened this issue 1 year ago • 3 comments

~~Draft PR; CraftMetaItemFrame is (probably) currently non-functional, but I wanted to share progress so far.~~

The second commit is a rewrite based on https://github.com/PaperMC/Paper/pull/11107, ~~and I'm waiting on that PR to finalize changes here.~~

Concerns:

  • Do we have to care about entity ID being different for glow item frames? Does that warrant a separate GlowItemFrameMeta? Entity IDs only even seem to matter on spawn eggs.
  • Should CraftMetaItemFrame be wrapped in // Paper? It's in org.bukkit (because there were a nightmarish amount of access transformers until I moved it from io.papermc), but it's also a new file.

Please let me know your thoughts :D

TehBrian avatar Aug 15 '24 21:08 TehBrian

#11107 has been merged. I'll clean this up, test it, and then mark it ready for review.

TehBrian avatar Aug 17 '24 02:08 TehBrian

Is this PR still needed with the new item component API?

TehBrian avatar Nov 25 '24 00:11 TehBrian

Yea, the component API does not expose entity data.

lynxplay avatar Nov 25 '24 00:11 lynxplay