Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Add RayTraceConfiguration

Open notTamion opened this issue 1 year ago • 3 comments

closes #9942 Adds a RayTraceBuilder which can be constructed using a starting Location, direction and max distance. I am currently still unsure of how to integrate the raytrace methods on Block. I would definitely love to hear some feedback on that.

notTamion avatar Feb 10 '24 11:02 notTamion

Could you give me an example explanation specifically for RayTrace in mind? (i don't exactly understand what you mean) do you mean like a RayTrace class that can be constructed which holds all the info about the direction etc. and then gets passed into the raytrace method on World, LivingEntity etc.?

EDIT: i think i know what you mean now but i don't see the benefit in it. imo that just complicates stuff more

notTamion avatar Feb 10 '24 17:02 notTamion

what should be done regarding LivingEntity or Block? those interfaces only have methods for raytracing with the target of there own type

notTamion avatar Feb 11 '24 07:02 notTamion

Alright i am really not sure about this. I feel like the kind of RayTraceBuilder or RayTraceExecutor we had in the beginnning just feels better. Using a configuration where stuff like starting point, distance, direction all need to be adjusted for each use specificly doesn't seem very convenient. I guess in the example of the JoinConfiguration that just works better cause not that many variables need to be adjusted for each use.

notTamion avatar Feb 17 '24 18:02 notTamion