Issue with NFT

[meme404erc]

Hi,

we've deployed this new version of the contract but seems like there might be an issue with NFTs? Some users buying the token using Uniswap but do not see any NFT.

Etherscan link: https://etherscan.io/address/0x009bfab2a411d32954a180ae1c1e61d2cc43a4ac Contract address: 0x009bfab2a411d32954a180ae1c1e61d2cc43a4ac

[myst4]

I have the same problem, mint some nft to test account, erc721 balance looks rigth but I cant see the nft on opensea for example

do you have any luck @meme404erc ?

[myst4]

adding more data, when I used erc404 old library (took from pandora example repo) it works greats on opensea when I minted some nft, but when I use this one erc404 library, it is missing on opensea after mint, anyone knows what is happens?

thanks

[meme404erc]

@myst4 unfortunately no, they are ignoring this question here and in builders Telegram chat :(

[mathdroid]

checking @meme404erc @myst4 , super swamped few days back

[mathdroid]

I am not seeing any problems onchain. Maybe the issue is in Opensea?

[mathdroid]

so they HAVE the tokens, but there was no erc721transfer event in the last pic. I think this used an old version of the code. cc @caldereth @0xacme

[mathdroid]

need more e2e test: transfer from exempted pool @caldereth

[myst4]

@mathdroid yeap the nft looks fine in the contract, but in opensea or any nft market cant read the contract, I tried with the older erc404 library and after transfer or swap it appers in real time in opensea, but with this new erc404 library it not works on opensea

this is the nft contract builded with erc404 old (the same that is using pandora token)

https://opensea.io/assets/matic/0xc3a608429487b6dbb1177ec930f77b71e53cb4d4/3

and I followd the same steps using the example404.sol from this repo and I seems that not mints the nfts, just transfer all as erc20 tokens for that reason seems that opensea cant read it

https://opensea.io/assets/matic/0xb94647FE572A9f26Fe60c9BcEe1bE24320A9878f/2

it throws 404 error on opensea

any one idea ?

[myst4]

so they HAVE the tokens, but there was no erc721transfer event in the last pic. I think this used an old version of the code. cc @caldereth @0xacme

exactly, on the contracts looks all ok but never mint the nft

check this transfer

https://etherscan.io/tx/0xf7ff8c3c19381e5f5581dd59cb74ce2150f8df4fe5d60864cee533ce007abfc7

the user send 1667000000000000000 tokens (1,6) so it should mint 1 nft, but just sent all as erc20 tokens.

[mathdroid]

in #6 we have a test for this and it passed (events were emitted). will add a more thorough case @myst4

cc @0xacme @caldereth I think we should use old audited 404 in main branch, develop the new one in canary or other branch

[celsosa]

Same here, no nfts are being minted (and contract shows like the wallet have the nfts). We need to add a custom mint nft fuction on transfer or something? Or should work already in current protocol code?

[mathdroid]

@celsosa use v1 for now while we fix this

[myst4]

@mathdroid where is the last stable version of erc404?, is in some branch in this repo?

[gpsus]

Does anyone have a solution to this?

[smarter777]

@myst4 , @meme404erc I faced once this issue and solved on my end. Main reason of NFT is not be shown on Opensea is due to Transfer event. In ERC404-legacy version, there's event "Transfer" and emitted whenever ERC721 token is transferred, but not in ERC404 v2. Instead there's ERC721Transfer event. By adding Transfer event, I solved this issue because Opensea monitor the "Transfer" event, not ERC721Transfer event. Depending on your mind whether you would use Opensea or the others for NFT trading, but I sincerely recommend to this solution if you want to use Opensea NFT marketplace. Hope this solution would be help for you.

[0xacme]

Hey all, closing this for now given the released, current version has switched to standard events. You shouldn't be facing these issues anymore.

Feel free to open again if you see new issues on the current version of the implementation.