terraform-provider-panos Missing arguments after import

Missing arguments after import

Open trois-six opened this issue 3 years ago • 2 comments

Describe the bug

Hello!,

Working on https://github.com/GoogleCloudPlatform/terraformer/pull/939, I discovered that a number of resources have bugs after import.

Expected behavior

The provider should import all attributes, or at least the required attributes.

Current behavior

I encountered these bugs:

[ ] name attribute missing after import: panos_management_profile, panos_ike_crypto_profile, panos_ike_gateway, panos_ipsec_crypto_profile
[x] dynamic routes dist (ex: ospfv3_ext_dist) are set to 0 by default instead of the default value in panos_virtual_router
[ ] all Objects resources (common to the firewalls and Panorama) don’t have a vsys nor a device_group set
[ ] hip_profiles are not set in panos_security_rule_group
[ ] destination|source blocks are not set in the translated_packet in panos_nat_rule_group if the destination|source is not modified

Possible solution

Set these attributes on import.

Steps to reproduce

$ terraform import ... ...
$ terraform state show ...

Context

Development of the Terraformer provider for panos. Dedicated commit to create workarounds for this issue: https://github.com/GoogleCloudPlatform/terraformer/pull/939/commits/4f5a6a8d9ff3d2ba0027dfa50c4f49d391f1c23b.