prisma-cloud-scan icon indicating copy to clipboard operation
prisma-cloud-scan copied to clipboard

restore proxy feature

Open schdief opened this issue 9 months ago • 0 comments

Describe the bug

With https://github.com/PaloAltoNetworks/prisma-cloud-scan/commit/9fa3f562984245b0334b44865edd1432a5b04b87 the feature #11 was removed. Since there is no comment on why, I can only imagine it happened by mistake. But we need that feature to use the action for our internally running runners. Please revert the change and bring the functionality back.

Expected behavior

I can specify a proxy and it works.

Current behavior

Currently specifying the proxy leads to Unexpected input(s) 'http_proxy'

Possible solution

Revert unplanned removal with https://github.com/PaloAltoNetworks/prisma-cloud-scan/commit/9fa3f562984245b0334b44865edd1432a5b04b87

Steps to reproduce

    - name: Prisma Cloud image scan
      id: scan
      uses: PaloAltoNetworks/[email protected]
      with:
        pcc_console_url: ${{ secrets.PCC_CONSOLE_URL }}
        pcc_user: ${{ secrets.PCC_USER }}
        pcc_pass: ${{ secrets.PCC_PASS }}
        twistcli_debug: true
        http_proxy: proxy.acme.com:8080

Screenshots

Context

currently the action is unusable

Your Environment

GitHub Enterprise Server with ARC-Runners in AKS

schdief avatar May 06 '25 13:05 schdief