pc-python-integration icon indicating copy to clipboard operation
pc-python-integration copied to clipboard

Credentials file comments and PowerShell USERPROFILE for home directory

Open jumiles-pa opened this issue 5 months ago • 0 comments

Description

We found that the library fails if there are any comments in the credentials json files so to handle this I use the json5 library instead of the base json library that comes with python at this time. https://pypi.org/project/json5/

I also saw the library fail to find credential files when using PowerShell because the environment variable HOME would be missing. I set it to fall back onto USERPROFILE if the HOME variable is not set.

I also added more descriptive notes on how to test locally in the CONTRIBUTING.md file.

Motivation and Context

How Has This Been Tested?

I tested locally in a minimal capacity.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes if appropriate.
  • [x] All new and existing tests passed.

jumiles-pa avatar Jun 17 '25 21:06 jumiles-pa