pan-os-python icon indicating copy to clipboard operation
pan-os-python copied to clipboard

Published 20 hours ago • verified publisher icon PaloAltoNetworks

Fixes #463. Expose LLDP neighbors on EthernetInterface

Open DavidVentura opened this issue 3 years ago • 1 comments

Description

This change adds a new function: get_lldp_neighbors to EthernetInterface, which returns a list of LLDP neighbors from the device.

Motivation and Context

LLDP is very useful to determine whether patching was carried out correctly, see #463

How Has This Been Tested?

I am testing this on a PA-850.

Lint rules from the contributing guidelines were broken prior to this change

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes if appropriate.
  • [x] All new and existing tests passed.

I have not added tests, I couldn't find a test for get_counters to base my test on, is there a similar test I can use as an example?

DavidVentura avatar Jul 06 '22 13:07 DavidVentura

:tada: Thanks for opening this pull request! We really appreciate contributors like you! :raised_hands:

welcome-to-palo-alto-networks[bot] avatar Jul 06 '22 13:07 welcome-to-palo-alto-networks[bot]