talawa icon indicating copy to clipboard operation
talawa copied to clipboard

Assignment Error in User Model (user_info.dart)

Open MariaMckenzie opened this issue 4 years ago • 10 comments

Expected Documentation: Correct assignment of variables and attributes. image Current Documentation: Error in variable assignments. (details.firstname is assigned to this.lastName, this.email and this.image) image Possible Solution: Change the variables being assigned. Steps to Reproduce: N/A Context (Environment): The development of code
Detailed Description: N/A Possible Implementation: N/A

MariaMckenzie avatar Oct 22 '21 15:10 MariaMckenzie

I fixed it , pls review the changes

ayush-mahawar26 avatar Oct 23 '21 07:10 ayush-mahawar26

@ayush-mahawar26 please don't make PRs until the issue is assigned.

CyberWake avatar Oct 25 '21 08:10 CyberWake

@MariaMckenzie nice observations. Thanks for marking. If you will work on this let me know ASAP or else I'll assign this to @ayush-mahawar26.

CyberWake avatar Oct 25 '21 08:10 CyberWake

@CyberWake Im very sorry , Im beginner for open source contribution , so I dont know that . Actually have fixed this and created pull request (For which Im very sorry) , So now I have to cancelled the pull request or let it be requested ?

ayush-mahawar26 avatar Oct 25 '21 13:10 ayush-mahawar26

no worries but please don't get started this way ask in the slack channel if needed. Only wanted to help all since this may lead to 2 or more pull requests for the same issue. So it's better to get them assigned and then work on them. This would help both the author and the collaborators.

CyberWake avatar Oct 26 '21 19:10 CyberWake

Is this issue solved? if not i would like to work on it. thanks!

M-A-D-A-R-A avatar Dec 04 '21 03:12 M-A-D-A-R-A

@ayush-mahawar26 Are you still working on this?

palisadoes avatar Dec 04 '21 18:12 palisadoes

@palisadoes I resolved this issue , waiting for @utkarshshendge to review it , BTW it is reviewed by CyberWake and he approoved it

ayush-mahawar26 avatar Dec 14 '21 08:12 ayush-mahawar26

@ayush-mahawar26 Is there a pull request for this? Please submit one if not.

palisadoes avatar Dec 14 '21 13:12 palisadoes

@palisadoes Yes , submitted the pull request

ayush-mahawar26 avatar Dec 14 '21 14:12 ayush-mahawar26