talawa
talawa copied to clipboard
Unittests for widget organization_list.dart
- Please coordinate issue assignment and PR reviews with the contributors listed in this issue https://github.com/PalisadoesFoundation/talawa/issues/359
We will need unittests done for all methods, classes and functions found in this file.
Any widgets referenced in this file must also have unittests done
organization_list.dart
This file can be found in the lib/widgets
directory
Parent Issue:
- https://github.com/PalisadoesFoundation/talawa/issues/1125
PR Acceptance Criteria
- When complete this file must show 100% coverage when merged into the code base.
- The current code coverage for the file can be found here
- The PR will show a report for the code coverage for the file you have added. You can use that as a guide
- No functionality must be removed to achieve this goal
Hi can I work on this one?
Can you assign this issue to me @palisadoes ?? As no activity from vedant
@palisadoes can you assign this issue to me??
Unassigned due to inactivity.
This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
Can you assign this to me
As mentioned in Slack, this week contributor @aashimawadhwa is handling all new issue assignments and seeking reviewers for PRs. Please work with them to coordinate these activities.
@aashimawadhwa ma'am can you assign this to me
No response
assigned to you @nidhin29
Sorry I am not able to do it
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
@aashimawadhwa Kindly assign this issue to me
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
Can I work on this issue @Cioppolo14?
Actually I would be requiring sample data of Organization which also have Users as members and admins for this test. So should I create it by myself or there would be something from API side?
@Manik2708 for testing purpose we use hard-coded mock data. Nothing comes from API.
@Manik2708 for testing purpose we use hard-coded mock data. Nothing comes from API.
No I was thinking to create reusable sample data because creating mock organization and user takes time. So it will save time for developers!
Will it come from API side?
That's what I am asking!
I suggest you to ask mentors.
@noman2002 @Ayush0Chaudhary @literalEval I am suffering from a problem when testing the Query Hook Widget
, the mock query is not getting called inside this widget when following the same approach as in fetch_plugin_list_test.dart
, I am getting nothing on searching for writing tests including this widget. Can I get reason for using this widget in this file and not invoking the query directly? As this Query
widget is used only in this file!
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
I was trying for this from last two weeks, but was not able to mock the behaviour of Query
widget.There is a reason for this and so, I have raised an issue regarding this in GraphQL, @literalEval @noman2002 please see this issue and see if it can be fixed, as I am not able to get it's solution.
Hey @Manik2708 is the mock for Query widget generated ?
No, please refer to the issue https://github.com/zino-hofmann/graphql-flutter/issues/1408 There is a problem in sending mock query. Let me explain my approach, please see if something wrong.
- There is a test written related to GraphQL query,
plugins/fetch_,plugins_list.dart
. I am following the same approach. - Mocking of client is successful but sending a query is failing.
result.data
is always coming null. - I went to the API reference of this
Query
widget, it's a widget which is extendingHookWidget
- The method which is being used for fetching query in this widget is not wrapped in any class, hence I am not able to mock it. This method is directly declared and implemented in the file. I searched a lot on Google and Stack Overflow but found nothing. Hence I raised an issue in the package, so that I could find a way of mocking it or they could fix it if it's a bug!
I think this is why most of assignees were not able to complete this issue. I maybe wrong. Please verify my approach! Thanks.
@Manik2708 Thank you for letting us know the exact problem, your approach is fine. Let's figure out some alternates for this.
I searched a bit for the solution, found that we can create our own HookWidget. Reference to Flutter Hooks: https://pub.dev/packages/flutter_hooks. Reference from graphql_flutter
explaining the use of hooks: https://pub.dev/packages/graphql_flutter#query
Till then unassigning myself.