talawa icon indicating copy to clipboard operation
talawa copied to clipboard

UI changes

Open ItsAdityaKSingh opened this issue 3 years ago • 8 comments

Describe the bug The current UI for dark mode is not appealing or does not showcase the important parts of the app. The Circular loading button can be improved. On the Chats screen, the tab color has a different green than the one used all over the app. From the onboarding screen to various Page titles and content, it can be improved with typical and custom talawa colors!

To Reproduce Steps to reproduce the behavior:

  1. Open App in Dark Mode
  2. See the onboarding screen for the first time
  3. Switch between Screens to see dull UI

Expected behavior A clear UI theme and colors could be used, highlighting the main parts and titles with brighter shades.

Actual behavior The UI was dull and unappealing for a user.

Screenshots Screenshot 2022-01-03 at 3 34 26 PM

Additional details The UIs need to be consistent with App's overall color scheme and look appealing and noticeable.

ItsAdityaKSingh avatar Jan 03 '22 10:01 ItsAdityaKSingh

@palisadoes I would like to work on this issue and improve the UI for the better!

ItsAdityaKSingh avatar Jan 03 '22 10:01 ItsAdityaKSingh

@rutvik11062000 What do you think? I'd greatly prefer changes to meet your design specification.

palisadoes avatar Jan 03 '22 17:01 palisadoes

@ItsAdityaKSingh We have raised our code coverage percentage to 34%, so you'll need to add tests to this issue for the PRs to be approved.

palisadoes avatar Jan 03 '22 17:01 palisadoes

@ItsAdityaKSingh We have raised our code coverage percentage to 34%, so you'll need to add tests to this issue for the PRs to be approved.

So, basically, will I need to write tests first for the particular widgets or UI components I want to change?

ItsAdityaKSingh avatar Jan 03 '22 19:01 ItsAdityaKSingh

Yes

palisadoes avatar Jan 03 '22 19:01 palisadoes

Ok. Could you help me by guiding me in a direction to start writing tests, like from which widget or function should I start unit testing so as to be able to resolve this issue?

ItsAdityaKSingh avatar Jan 03 '22 19:01 ItsAdityaKSingh

@ItsAdityaKSingh

This should give you an idea of how to proceed on widgets and other code.

  • Any code you submit must be tested.
  • If your code uses any widget, then you must ensure that the widget in question has a test too.

palisadoes avatar Jan 03 '22 19:01 palisadoes

@ItsAdityaKSingh

This should give you an idea of how to proceed on widgets and other code.

  • Any code you submit must be tested.
  • If your code uses any widget, then you must ensure that the widget in question has a test too.

Sure. Thanks a ton!

ItsAdityaKSingh avatar Jan 03 '22 20:01 ItsAdityaKSingh