talawa-api
talawa-api copied to clipboard
Resolvers: Create tests for removeDirectChat.js
The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.
Tests need to be written for file lib/resolvers/direct_chat_mutations/removeDirectChat.js
- We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
- When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
single file with the name
tests/resolvers/direct_chat_mutations/removeDirectChat.spec.js. You may need to create the appropriate directory structure to do this.
IMPORTANT:
Please refer to the parent issue on how to implement these tests correctly:
- https://github.com/PalisadoesFoundation/talawa-api/issues/490
PR Acceptance Criteria
- When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
- The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
- The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
I'd like to work on this issue.
We are at 94% coverage on the file. This issue has to be reopened.
- https://app.codecov.io/gh/PalisadoesFoundation/talawa-api/blob/develop/lib/resolvers/direct_chat_mutations/removeDirectChat.js
@xoldyckk I may have been too quick to revert this PR. I was reviewing past slack posts.
- Is it at all possible to get to 100% coverage for these cases?
- Will we have to discount the ternary operator checking for
productionin all our PRs when evaluating coverage.
Hello @xoldyckk It's been over 6 months and associated PRs are also closed I will unassign you.