talawa-api icon indicating copy to clipboard operation
talawa-api copied to clipboard

User membershipRequest showing unexpected behavior

Open Azad99-9 opened this issue 10 months ago • 17 comments

Describe the bug before testing set org's userRegistrationRequired: true.

Three cases of unexpected behaviour related to membershipRequests

case 1. Everytime register with a fresh account, new membershipRequest is being added to org's membershipRequests field but not to user's membershipRequests field.

case 2. Even if the requests are being added to the org's membershipRequests field but they are not fetchable in the org's query.

case 3. As soon as we send a request through the sendMembershipRequest mutation all the previously added requests are also now fetchable.

To Reproduce Steps to reproduce the behavior:

Case 1:

  1. Register with a fresh account
  2. check the org's membershipRequests field
  3. check the new user's membershipRequests field You will notice the membershipRequest is will be added to the org's membershipRequests field but the same will not be reflected in the user's membershipRequests field.

case 1.webm

Case 2:

  1. signup with multiple new accounts to a single org.
  2. Now compare org's membershipRequests list in the database and the membershipRequests list fetched by the organizations query. you will notice a mismatch of number of requests.

https://github.com/PalisadoesFoundation/talawa-api/assets/120930148/161d1161-e841-47f2-a722-fcaf96b6a737

Remember this org to reproduce case 3.

Case 3:

  1. Signup with a fresh account by choosing an org different from the org used in case 2.
  2. Now use sendMembershipRequest mutation and send a request to the org said in case 2.
  3. Now compare org's membershipRequests list in the database and the membershipRequests list fetched by the organizations query. you will notice the mismatch of number of requests disappears.

https://github.com/PalisadoesFoundation/talawa-api/assets/120930148/961e8ca9-d89e-4da9-8e1a-156200b8b1bd

Additional details Add any other context or screenshots about the feature request here.

Potential internship candidates Please read this if you are planning to apply for a Palisadoes Foundation internship https://github.com/PalisadoesFoundation/talawa/issues/359

Azad99-9 avatar Apr 21 '24 11:04 Azad99-9

I would like to work on it .

AVtheking avatar Apr 22 '24 03:04 AVtheking

Assign me this issue please

hg6658 avatar Apr 22 '24 10:04 hg6658

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar May 03 '24 00:05 github-actions[bot]

Hey @AVtheking any update on this?

Azad99-9 avatar May 11 '24 09:05 Azad99-9

Hi @Azad99-9 was busy due to my exams.. will start working on it from tomorrow.

AVtheking avatar May 11 '24 11:05 AVtheking

Unassigning myself busy in some other issue.

AVtheking avatar May 19 '24 15:05 AVtheking

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar May 30 '24 00:05 github-actions[bot]

I would like to work on this issue

Chaitanya1672 avatar Jun 24 '24 09:06 Chaitanya1672

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jul 05 '24 00:07 github-actions[bot]

Working on it

Chaitanya1672 avatar Jul 05 '24 04:07 Chaitanya1672

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jul 16 '24 00:07 github-actions[bot]

I am unassigning myself from my due to being occupied with other commitments.

Chaitanya1672 avatar Jul 20 '24 13:07 Chaitanya1672

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar Aug 01 '24 00:08 github-actions[bot]

Can I be assigned this issue?

syedali237 avatar Aug 25 '24 11:08 syedali237

Working on it might take a few days..

syedali237 avatar Sep 07 '24 10:09 syedali237

I've fixed case 1. Would you prefer I submit a PR for this now, or should I complete the fixes for the other two cases first and then make a single PR?

syedali237 avatar Sep 11 '24 10:09 syedali237

please do everything in a single PR and share a video of it too.

Azad99-9 avatar Sep 11 '24 11:09 Azad99-9