talawa-admin icon indicating copy to clipboard operation
talawa-admin copied to clipboard
verified publisher icon PalisadoesFoundation

Upgrade package `typescript` from 4.9.5 to 5.4.5

Open palisadoes opened this issue 1 year ago • 19 comments

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade package typescript from 4.9.5 to 5.4.5
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs

  • https://github.com/PalisadoesFoundation/talawa-admin/pull/2014
  • https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/9247355671/job/25436082785?pr=2014
  • https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/9247355543/job/25436082385?pr=2014

Release Note Details

Bumps typescript from 4.9.5 to 5.4.5.

Release notes

Sourced from typescript's releases.

TypeScript 5.4.5

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.4.4

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.4.3

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.4

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

... (truncated)

Commits
  • 27bcd4c Update LKG
  • 9f33bf1 🤖 Pick PR #58098 (Fix constraints of nested homomorph...) into release-5.4 (#...
  • 71b2f84 Bump version to 5.4.5 and LKG
  • 892936f 🤖 Pick PR #58083 (Don't propagate partial union/inter...) into release-5.4 (#...
  • 38a7c05 release-5.4: Always set node-version for setup-node (#58117)
  • b754fc3 🤖 Pick PR #57778 (fix type import check for default-i...) into release-5.4 (#...
  • 8eb3367 Bump version to 5.4.4 and LKG
  • de9096b 🤖 Pick PR #57871 (Divide-and-conquer strategy for int...) into release-5.4 (#...
  • 06aae98 🤖 Pick PR #57973 (Compare package.json paths with cor...) into release-5.4 (#...
  • 6d8134e 🤖 Pick PR #57637 (Fixed a regression related to deter...) into release-5.4 (#...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

palisadoes avatar May 27 '24 18:05 palisadoes

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jun 07 '24 00:06 github-actions[bot]

Can I take this issue? @palisadoes

MadhaneeswaranP avatar Jul 08 '24 06:07 MadhaneeswaranP

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jul 21 '24 00:07 github-actions[bot]

Unassigning no activity

palisadoes avatar Jul 25 '24 20:07 palisadoes

Hey!! @palisadoes , i would like to work on this issue, please assign me

Spoorthy1423 avatar Jul 28 '24 13:07 Spoorthy1423

@Spoorthy1423 You need to get assigned the issue first and submit a PR. Hope you can remind and abide this rule from next time which is one of our community guidelines

varshith257 avatar Jul 28 '24 13:07 varshith257

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar Aug 08 '24 00:08 github-actions[bot]

Unassigning due to no activity or PR.

Cioppolo14 avatar Aug 08 '24 12:08 Cioppolo14

Hello @Cioppolo14 @palisadoes I would like to work on this issue, if possible can you assign this to me. I will raise a draft PR asap.

ManjariRathore avatar Aug 12 '24 15:08 ManjariRathore

@ManjariRathore you are requesting to work on many issues. You can only be assigned 2 at a time. Please indicate which 2 are your priorities. Thank you.

Cioppolo14 avatar Aug 12 '24 17:08 Cioppolo14

@palisadoes kindly assign me this issue

VanshikaSabharwal avatar Aug 19 '24 06:08 VanshikaSabharwal

@varshith257 I have created pull request regarding this issue. Can you please have a look at it. [https://github.com/PalisadoesFoundation/talawa-admin/pull/2207]

VanshikaSabharwal avatar Aug 20 '24 12:08 VanshikaSabharwal

@VanshikaSabharwal Follow this https://github.com/PalisadoesFoundation/talawa-admin/pull/2208#issuecomment-2299088446

If you face any difficult reach out me in Slack

varshith257 avatar Aug 20 '24 15:08 varshith257

@VanshikaSabharwal Follow this #2208 (comment)

If you face any difficult reach out me in Slack

okay @varshith257

VanshikaSabharwal avatar Aug 20 '24 16:08 VanshikaSabharwal

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar Aug 31 '24 00:08 github-actions[bot]

Unassigning. Inactivity

palisadoes avatar Aug 31 '24 18:08 palisadoes

Please assign

adithyanotfound avatar Sep 06 '24 18:09 adithyanotfound

CRA (create-react-app) only supports up to TypeScript version 4.9.5. For better TypeScript compatibility and potential performance benefits, migrating to Vite or preferably Next.js is recommended. If you want me to migrate to Vite please assign Issue https://github.com/PalisadoesFoundation/talawa-admin/issues/1864.

NOTE: Migrating to Vite may introduce a few issues in deployment that you'll need to address. For now, you could continue using CRA and wait for a future update that supports newer TypeScript versions.

adithyanotfound avatar Sep 07 '24 15:09 adithyanotfound

OK. We are using vite in the API. So there is precedent. We need the consistency.

palisadoes avatar Sep 08 '24 19:09 palisadoes