talawa-admin icon indicating copy to clipboard operation
talawa-admin copied to clipboard

Redesign of Posts screen for talawa user portal.

Open git-init-priyanshu opened this issue 10 months ago • 14 comments

What kind of change does this PR introduce? UI redesign.

Issue Number:

Fixes #1514

Did you add tests for your changes? Not yet.

Snapshots/Videos:

https://github.com/PalisadoesFoundation/talawa-admin/assets/110045644/fd3fe77f-dcf1-4a56-b427-44c369cd5cf3 image

image

If relevant, did you update the documentation? No.

Summary

Does this PR introduce a breaking change? No.

Other information This PR is still in progress.

Have you read the contributing guide? Yes.

git-init-priyanshu avatar Apr 10 '24 14:04 git-init-priyanshu

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. :dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

github-actions[bot] avatar Apr 10 '24 14:04 github-actions[bot]

@git-init-priyanshu Please fix the linting issue.

Cioppolo14 avatar Apr 11 '24 00:04 Cioppolo14

@git-init-priyanshu i think the design doesn't matches with the figma design. Also, looks like the View Post button doesn't actually work here.

beingnoble03 avatar Apr 11 '24 04:04 beingnoble03

@git-init-priyanshu i think the design doesn't matches with the figma design. Also, looks like the View Post button doesn't actually work here.

Yes. In the figma design I could not understand why is there a 'Browse File' button next to the input area in the Figma design. Where will the title and description be placed? And for the 'View Post' button, I am working on it. image

git-init-priyanshu avatar Apr 11 '24 06:04 git-init-priyanshu

Hey @aashimawadhwa, I have made View Post modal UI. It is not included in the Figma file so I created one. I would like to know your opinion. Thanks. image

git-init-priyanshu avatar Apr 11 '24 19:04 git-init-priyanshu

Please fix the conflicting files

palisadoes avatar Apr 12 '24 00:04 palisadoes

I finally understood the Figma design and made the designs accordingly. image

git-init-priyanshu avatar Apr 13 '24 06:04 git-init-priyanshu

Please fix the conflicting files. It looks good otherwise.

palisadoes avatar Apr 14 '24 19:04 palisadoes

Please fix the conflicting files. It looks good otherwise.

Yes sir. I have my exams next week so I am trying to finish this before that. I will try to finish this ASAP.

git-init-priyanshu avatar Apr 14 '24 20:04 git-init-priyanshu

Good luck with your exams. Thanks

palisadoes avatar Apr 14 '24 21:04 palisadoes

Should I also add functionality to these dropdown items? image

git-init-priyanshu avatar Apr 15 '24 06:04 git-init-priyanshu

Don't have the share, and pin post icons.

  1. Pinned posts are only for Admins via the Admin portal.
  2. We can add sharing at a later stage.

palisadoes avatar Apr 15 '24 13:04 palisadoes

Please fix type errors

pranshugupta54 avatar Apr 21 '24 06:04 pranshugupta54

Please fix the failing tests

palisadoes avatar Apr 21 '24 06:04 palisadoes

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

github-actions[bot] avatar May 02 '24 00:05 github-actions[bot]

Please fix the failing test

palisadoes avatar May 05 '24 19:05 palisadoes

Codecov Report

Attention: Patch coverage is 97.64706% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.23%. Comparing base (872414a) to head (30261c3).

:exclamation: Current head 30261c3 differs from pull request most recent head b73be99. Consider uploading reports for the commit b73be99 to get more accurate results

Files Patch % Lines
src/screens/UserPortal/Posts/Posts.tsx 95.45% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1896      +/-   ##
===========================================
- Coverage    98.26%   98.23%   -0.03%     
===========================================
  Files          210      210              
  Lines         5693     5724      +31     
  Branches      1703     1706       +3     
===========================================
+ Hits          5594     5623      +29     
- Misses          93       95       +2     
  Partials         6        6              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 07 '24 15:05 codecov[bot]

Please do not merge this PR right now. I am adding edit post and delete post functionalities.

git-init-priyanshu avatar May 07 '24 17:05 git-init-priyanshu

This PR is ready to merge now If everything seems fine.

git-init-priyanshu avatar May 09 '24 09:05 git-init-priyanshu