talawa-admin
talawa-admin copied to clipboard
Add Support for Event Invitees and Registrants
What kind of change does this PR introduce? https://github.com/PalisadoesFoundation/talawa-admin/issues/1606
Issue Number:
Fixes #1606
Did you add tests for your changes? Still working on them
Snapshots/Videos: None
If relevant, did you update the documentation? Not relevant
Summary
Does this PR introduce a breaking change? No
Other information
Have you read the contributing guide?
Our Pull Request Approval Process
We have these basic policies to make the approval process smoother for our volunteer team.
Testing Your Code
Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
- The overall code coverage drops below the target threshold of the repository
- Any file in the pull request has code coverage levels below the repository threshold
- Merge conflicts
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Reviewers
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
- comments in this PR or
- our slack channel
Reviewing Your Code
Your reviewer(s) will have the following roles:
- arbitrators of future discussions with other contributors about the validity of your changes
- point of contact for evaluating the validity of your work
- person who verifies matching issues by others that should be closed.
- person who gives general guidance in fixing your tests
CONTRIBUTING.md
Read our CONTRIBUTING.md file. Most importantly:
- PRs with issues not assigned to you will be closed by the reviewer
- Fix the first comment in the PR so that each issue listed automatically closes
Other
- :dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
- Read the CONTRIBUTING.md file make
@AdityaRaimec22 please fix the conflicts
@AdityaRaimec22 It also doesn't look like all checks ran.
@AdityaRaimec22 It also doesn't look like all checks ran.
Yes, because of the conflicts once they are removed the tests will run, Currently I am writing tests of this PR, I will push them ASAP and then I will remove the conflicts.
Please fix the merge conflicts
Hey @AdityaRaimec22, are you facing any issues?
Please add a video to better illustrate your update
@AdityaRaimec22, have the linting errors been fixed? Or do you need any help? Let me know.
@AdityaRaimec22 Are you still working on this?
@AdityaRaimec22 Are you still working on this?
All the changes are made and PR is created but some of the tests are failing which the PR will pass soon once my exams are over. Thanks.
Will you be able to revisit this?
Will you be able to revisit this?
Yes, My exams are just over and now I will be able to contribute regularly so I will finish this.
@AdityaRaimec22 Fix the linting errors