talawa-admin icon indicating copy to clipboard operation
talawa-admin copied to clipboard

Add Support for Event Invitees and Registrants

Open AdityaRaimec22 opened this issue 4 months ago • 10 comments

What kind of change does this PR introduce? https://github.com/PalisadoesFoundation/talawa-admin/issues/1606

Issue Number:

Fixes #1606

Did you add tests for your changes? Still working on them

Snapshots/Videos: None

If relevant, did you update the documentation? Not relevant

Summary

Does this PR introduce a breaking change? No

Other information

Have you read the contributing guide?

AdityaRaimec22 avatar Apr 02 '24 14:04 AdityaRaimec22

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. :dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

github-actions[bot] avatar Apr 02 '24 14:04 github-actions[bot]

@AdityaRaimec22 please fix the conflicts

Olatade avatar Apr 02 '24 14:04 Olatade

@AdityaRaimec22 It also doesn't look like all checks ran.

Cioppolo14 avatar Apr 04 '24 12:04 Cioppolo14

@AdityaRaimec22 It also doesn't look like all checks ran.

Yes, because of the conflicts once they are removed the tests will run, Currently I am writing tests of this PR, I will push them ASAP and then I will remove the conflicts.

AdityaRaimec22 avatar Apr 04 '24 13:04 AdityaRaimec22

Please fix the merge conflicts

palisadoes avatar Apr 06 '24 13:04 palisadoes

Hey @AdityaRaimec22, are you facing any issues?

pranshugupta54 avatar Apr 11 '24 04:04 pranshugupta54

Please add a video to better illustrate your update

palisadoes avatar Apr 17 '24 13:04 palisadoes

@AdityaRaimec22, have the linting errors been fixed? Or do you need any help? Let me know.

duplixx avatar Apr 17 '24 15:04 duplixx

@AdityaRaimec22 Are you still working on this?

Cioppolo14 avatar Apr 22 '24 12:04 Cioppolo14

@AdityaRaimec22 Are you still working on this?

All the changes are made and PR is created but some of the tests are failing which the PR will pass soon once my exams are over. Thanks.

AdityaRaimec22 avatar Apr 22 '24 13:04 AdityaRaimec22

Will you be able to revisit this?

palisadoes avatar May 05 '24 19:05 palisadoes

Will you be able to revisit this?

Yes, My exams are just over and now I will be able to contribute regularly so I will finish this.

AdityaRaimec22 avatar May 09 '24 06:05 AdityaRaimec22

@AdityaRaimec22 Fix the linting errors

gautam-divyanshu avatar May 11 '24 07:05 gautam-divyanshu