talawa-admin icon indicating copy to clipboard operation
talawa-admin copied to clipboard

Issue templating

Open pranshugupta54 opened this issue 11 months ago • 11 comments

What kind of change does this PR introduce?

Issue Number:

Ref #1774

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

pranshugupta54 avatar Mar 23 '24 20:03 pranshugupta54

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. :dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

github-actions[bot] avatar Mar 23 '24 20:03 github-actions[bot]

@palisadoes Please check the files for any suggestions for improvements of descriptions of placeholders in both files to make it more readable

varshith257 avatar Mar 23 '24 20:03 varshith257

I'm not familiar with the syntax for this.

  1. Are the checkbox values going to be represented by a Yes or No value on submission?

palisadoes avatar Mar 23 '24 21:03 palisadoes

I'm not familiar with the syntax for this.

  1. Are the checkbox values going to be represented by a Yes or No value on submission?

@palisadoes, you can test it here https://github.com/pranshugupta54/talawa-docs/issues/new/choose

pranshugupta54 avatar Mar 23 '24 21:03 pranshugupta54

I'm not familiar with the syntax for this.

  1. Are the checkbox values going to be represented by a Yes or No value on submission?

@palisadoes Check out his changes here : https://github.com/pranshugupta54/talawa-docs/issues/new/choose

varshith257 avatar Mar 23 '24 21:03 varshith257

@palisadoes Have a look at it

varshith257 avatar Mar 24 '24 18:03 varshith257

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.37%. Comparing base (1abea97) to head (a68bd8a). Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1777   +/-   ##
========================================
  Coverage    98.37%   98.37%           
========================================
  Files          198      198           
  Lines         5040     5040           
  Branches      1466     1465    -1     
========================================
  Hits          4958     4958           
  Misses          77       77           
  Partials         5        5           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 01 '24 15:04 codecov[bot]

  1. This is too many options. Old and New
  2. We need a single custom option of using pre-populated text like the ones we have now. Text that would cover both features and bugs without having separate feature and bug sections. It'll have to be generic

palisadoes avatar Apr 02 '24 16:04 palisadoes

  1. This is too many options. Old and New
  2. We need a single custom option of using pre-populated text like the ones we have now. Text that would cover both features and bugs without having separate feature and bug sections. It'll have to be generic

Implemented a generic template:

image

Pre-populated text:

image

pranshugupta54 avatar Apr 03 '24 21:04 pranshugupta54

Fixed all

pranshugupta54 avatar Apr 08 '24 01:04 pranshugupta54

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

github-actions[bot] avatar Apr 19 '24 00:04 github-actions[bot]

I'm going to close this. We have more pressing priorities.

palisadoes avatar May 05 '24 19:05 palisadoes