talawa-admin icon indicating copy to clipboard operation
talawa-admin copied to clipboard

Bug Report: When language preferences are switched, the warnings for invalid inputs are still showing in English

Open Cioppolo14 opened this issue 1 year ago • 14 comments

Describe the bug When the preferred language is not english, warnings (both in top right or below the log in credentials) are not showing in the preferred language. They remain in English.

To Reproduce Steps to reproduce the behavior:

  1. Set language on login page to any language except English
  2. Attempt to login with bad credentials
  3. Observe the warnings remaining in English

Expected behavior Once the preferred language is chosen, all the following must be in the preferred language on the admin and user portal pages:

  1. All notifications
  2. All warnings and errors
  3. All text

Screenshots

The following are provided as only one of many other examples of this issue.

Screenshot 2024-02-11 134100

Screenshot 2024-02-11 134133

Additional Details The location of language translation files is here: /talawa-admin/tree/develop/public/locales

Potential internship candidates Please read this if you are planning to apply for a Palisadoes Foundation internship https://github.com/PalisadoesFoundation/talawa/issues/359

Cioppolo14 avatar Feb 11 '24 18:02 Cioppolo14

Congratulations on making your first Issue! :confetti_ball: If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

github-actions[bot] avatar Feb 11 '24 18:02 github-actions[bot]

@Cioppolo14 Please assign me this Issue

Sauradip07 avatar Feb 11 '24 18:02 Sauradip07

@Cioppolo14 Please assign me this Issue

ParishiB avatar Feb 11 '24 18:02 ParishiB

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar Feb 22 '24 00:02 github-actions[bot]

I am currently working on this issue please don't unassigned me

Sauradip07 avatar Feb 23 '24 05:02 Sauradip07

Hi, Is the issue still perssit can I work on this issue pls

dhruvgupta0503 avatar Mar 08 '24 07:03 dhruvgupta0503

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar Mar 19 '24 00:03 github-actions[bot]

Unassigning due to no activity or open PR

Cioppolo14 avatar Mar 19 '24 11:03 Cioppolo14

@Cioppolo14 Please assign me this issue

gautam-divyanshu avatar Mar 23 '24 19:03 gautam-divyanshu

please assign this issue to me

anuragnegi000 avatar Apr 01 '24 13:04 anuragnegi000

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

github-actions[bot] avatar Apr 13 '24 00:04 github-actions[bot]

Unassigning, inactivity and no submitted PR

palisadoes avatar Apr 13 '24 03:04 palisadoes

Please assign this issue to me.

akhilender-bongirwar avatar Apr 16 '24 10:04 akhilender-bongirwar

I can work on this

pranshugupta54 avatar Apr 22 '24 10:04 pranshugupta54

We need to plan more on fixing this completely. Temporary fix is going to be a very bad practice by checking strings directly. We need either API to send error codes or send translated directly.

Discussion: https://thepalisadoes-dyb6419.slack.com/archives/C01RPC00K0D/p1713875221323299

pranshugupta54 avatar Apr 29 '24 06:04 pranshugupta54

Reference: https://github.com/PalisadoesFoundation/talawa-api/issues/2383

pranshugupta54 avatar Jul 05 '24 20:07 pranshugupta54