talawa-admin
talawa-admin copied to clipboard
Admin - Select organization on registration
Is your feature request related to a problem? Please describe.
We are working on migrating the approval of requests to join organizations to a new Admin screen as outlined in this issue:
- https://github.com/PalisadoesFoundation/talawa-admin/issues/1416
Prior to this the process was:
- New registrants joined the Community
- Super Admins would approve the request
- Approved registrants would login and select an organization
There were disadvantages to this approach:
- This gave too much responsibility to the Super Admin who may not necessarily know people requesting to join in the way an Admin would.
- The two step process where the organization was selected post approval, could have been reduced to a simpler single step.
Describe the solution you'd like
TALAWA API
- This new requirement means that:
- New
USER
s andNON_USER
s will need to select an organization when registering so that the request can be directed to the correct organization's Admin screens. - The setup script needs to create a single organization with a generic name on installation to facilitate registration to choice of at least one organization
- There can never be less than one organization in the DB
- The registration mutation must include organization ID information that issue https://github.com/PalisadoesFoundation/talawa-admin/issues/1416 will be able to detect.
- The current GitHub action pull request workflow needs to be updated so that the default organization is created successfully. This is in addition to the already existing test data importation test.
- The default organization creation mode mutation needs set the registration approval required flag to True to err on the side of caution.
- New
TALAWA MOBILE
- This new requirement means that:
- The user registration screen(s) will need to prompt for the organization and use the updated
Talawa API
registration mutation. - The screen(s) design must follow the guidelines of our Design System found here:
- https://docs.talawa.io/docs/design/ux/ux-design-system
- The user registration screen(s) will need to prompt for the organization and use the updated
TALAWA ADMIN
- This new requirement means that:
- The user registration screen(s) will need to prompt for the organization and use the updated
Talawa API
registration mutation. - The screen(s) design must follow the guidelines of our Design System found here:
- https://docs.talawa.io/docs/design/ux/ux-design-system
- The user registration screen(s) will need to prompt for the organization and use the updated
OTHER
- You will need to write tests for the updated code
- All other functionality must be maintained
- We will need to add your Figma page designs to our official Figma document
Describe alternatives you've considered
- N/A
Approach to be followed (optional)
- See above
Additional context
- Related issues:
- https://github.com/PalisadoesFoundation/talawa-api/issues/1703
- https://github.com/PalisadoesFoundation/talawa/issues/2330
- https://github.com/PalisadoesFoundation/talawa-admin/issues/1440
- User definitions in the DB schema
Potential internship candidates Please read this if you are planning to apply for a Palisadoes Foundation internship
- https://github.com/PalisadoesFoundation/talawa/issues/359
Would like to contribute! Pls assign.
@palisadoes Can i work on the Talawa-admin part for this, please?
@palisadoes can i work on this?
@Sejal1411 Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.
I would like to work on the talawa-admin part of this issue please assign it to me
@Cioppolo14 I have unassigned myself from one of the issues. Can i get assigned to this issue?
@Sejal1411 i got this issue assigned already , maybe you can work on the api part for the same :eyes:
@Sejal1411 If this issue wasn't already assigned, at this point I could assign you. In the future, if you are first to comment requesting an issue and you really want that issue, make sure you have less than 2 total issues for when I go to do assignments. Thank you for understanding.
@karthxk07
- We will need to add your Figma page designs to our official Figma document
- Please plan for this
@karthxk07
- The blocking API PR for this issue has been merged.
- https://github.com/PalisadoesFoundation/talawa-api/pull/1741
- Please proceed with your work on this with urgency
@palisadoes I had been working on another issue and have been ignorant about this one. I will be immediately on this sir :+1:
@palisadoes Sir , in the select organization page, should the user have options to join multiple organizations or only one to start with. Can it be something like this where instead of topics we have organizations ?
One
@palisadoes Sir, Is something like this fine?
https://www.figma.com/file/CCUKLqu8AYb3uBGQrXLJwE/Untitled?type=design&node-id=0%3A1&mode=design&t=5FkVhuIFeHKU7avH-1
How can you make the selection a part of the existing registration screen?
@palisadoes Sir, maybe we can add a dropdown field to select from all available organisations?
Something like this? https://www.figma.com/file/6xACotBTh0GU3POVqZbMX0/Untitled?type=design&node-id=0%3A1&mode=design&t=4tJRjxZscGMivMpw-1
OK
When do you think you'll be able to raise a PR for this?
@palisadoes Sir , I have completed the frontend part , I am working on implementing the logic. I will make the PR ASAP or latest by this weekend.
@palisadoes Sir, Is this signUp mutation behavior expected, because in the above merged blocking PR , the expected output was somewhat different. How should I proceed about this?
If that case comment on the PR's issue with what you'd expect and let's reopen it to have the expected behavior
However, this PR was created to rectify a previously identified bug.
- https://github.com/PalisadoesFoundation/talawa-api/pull/1770
@palisadoes Sir, The PR is still pending to be merged, I will work on all the other things, and as soon as the blocking PR is merged I will implement the remaining functionality. :+1:
Also @karthxk07 The organization selection drop down design looks good !
@aashimawadhwa Thank you :blush: , @palisadoes Sir I have completed adding the other functionalities, does this look fine? Also as soon as the blocking PR is resolved , I will make the remaining changes :+1: . Should I open a pull request now or later
Please work with @aashimawadhwa. Submit a PR when ready.
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
@karthxk07 Are you still working on this?
@Cioppolo14 Yes Ma'am , there is a blocking PR related to this issue. It is currently under review to be merged I am ready with all the other changes , as soon as the blocking PR is merged i will start working on the remaining things and make a PR.
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.