talawa-admin
talawa-admin copied to clipboard
Talawa-Admin Docker Support Issue
Talawa-Admin Docker Support Issue:
Title: Adding Docker Support to Talawa-Admin
Description:
Problem: Talawa-Admin currently lacks Docker support, hindering its ease of deployment and scalability. Adding Docker support is essential to streamline the deployment process and make it more accessible to a broader audience.
Solution: Implementing Docker support for Talawa-Admin would involve creating a Dockerfile and configuration to package the application into a Docker container. This containerization would simplify deployment, improve consistency across environments, and enhance scalability.
Approach: To achieve Docker support for Talawa-Admin, we can follow these steps:
- Create a Dockerfile specifying the necessary dependencies and configuration.
- Configure the application to work seamlessly within a Docker container.
- Document the steps for building and running Talawa-Admin using Docker in the project's README.
Additional Context: Adding Docker support aligns with modern development practices, making it easier for developers to set up and run Talawa-Admin in various environments. Docker containers provide isolation, portability, and reproducibility, contributing to a more robust and user-friendly development and deployment experience.
Potential internship candidates Please read this if you are planning to apply for a Palisadoes Foundation internship https://github.com/PalisadoesFoundation/talawa/issues/359
Hey @palisadoes please assign me this issue. Thanks !!
@duplixx Do we even need docker on the admin? If yes, please explain why we need it.
Hey @noman2002 , I strongly believe that integrating Docker into Talawa-Admin is essential. It effectively addresses significant challenges faced by developers and contributors.
-
Reduces Setup Issues for Contributors:
- Docker ensures a standardized environment, minimizing setup issues for contributors.
- Facilitates a more consistent development environment for everyone involved.
-
Eliminates "It Works on My Machine" Problem:
- Docker eliminates the common challenge of code working differently on different machines.
- Developers can confidently share and collaborate on the same codebase without encountering environment-related discrepancies.
-
Ensures Consistency Across Environments:
- Talawa-Admin benefits from consistent environments across development, testing, and production.
- Docker ensures that the application behaves uniformly, mitigating issues related to environment variations.
-
Confident Collaboration:
- Developers can work on the same codebase without concerns about environment differences.
- Docker fosters confident collaboration, enabling a smoother development process.
In summary, leveraging Docker in Talawa-Admin significantly improves collaboration, consistency, and reduces common challenges associated with environment setups.
@kb-0311 @beingnoble03 @DMills27 @EshaanAgg would like to hear your thoughts on this.
Docker is essentially being used as a stop gap, at the moment, until we can put in place a more sustainable means to achieve reproducibility. I propose we have a single Docker image that generates the API, Admin and Talawa Mobile Frontend. My reasoning is that it would incur additional complexity to create separate Docker images for these and then connect them; it is also inefficient in terms of computational resources that would be used.
@DMills27
- You mean API and the web Admin/User portal correct?
- How would we best approach this if we are using separate repos for the API and Admin?
I could make a dockerfile for Talawa-Admin. I there is a need, Please assign this issue to me.
@DMills27
- You mean API and the web Admin/User portal correct?
- How would we best approach this if we are using separate repos for the API and Admin?
In my view we should follow this approach
1. Dockerfile for Each Component
- Create a Dockerfile for API and Admin.
- Specify base images with necessary dependencies.
2. Docker Compose for Multi-Container Setup
- Use Docker Compose for a multi-container setup.
- Define services, networks, and volumes in
docker-compose.yml
.
3. Service Orchestration
- Define dependencies between services.
- Use container names for inter-service communication.
@DMills27 @palisadoes Is this issue required or should we close this for now ??
It would only make sense for this issue if we publish the Talawa-API
as a docker image on DockerHub, and then use it to setup the admin via Compose. Otherwise there is no need for the same as of now IMO.
Thanks @EshaanAgg . Closing this for now.
@EshaanAgg As you spoke about publishing Talawa* on Docker Hub, should we reopen this issue?
We are yet to make a docker image for Talawa APi. It would be apt to reopen the same after it.
We are yet to make a docker image for Talawa APi. It would be apt to reopen the same after it.
The API got its docker instance created about 2 weeks ago. So we should reopen this issue.
can i get assigned?
@EshaanAgg @noman2002 is the talawa image is published on dockerhub i cant see it?
@palisadoes please assign this issue to me, would love to work
@palisadoes can i work on this issue!
Hey @aashimawadhwa and @palisadoes
I'm currently working on dockerizing Talawa Admin. To set up the Docker Compose file, I need the Docker image for Talawa API, but I couldn't find it anywhere.
Could you please guide me in the right direction or provide information about where I can obtain the Talawa API Docker image?
Thanks!
- You'll need to assume that the API is up and running.
- You will also need to update the setup script to accommodate the Docker support you'll be adding
- https://github.com/PalisadoesFoundation/talawa-admin/issues/1233
Okay, thanks!
You'll need to assume that the API is up and running.
You will also need to update the setup script to accommodate the Docker support you'll be adding
Hi @palisadoes,
I have created a PR to add dockerization support for talawa admin. Will update the setup script once that pr is merged to avoid conflicts.
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
Unassigning due to inactivity
@Cioppolo14 I would like to work on it
Reviewing the previously attempted work
@palisadoes @Cioppolo14 @noman2002 Can I raise an issue for potential improvements to Talawa-API
's Docker support? It's mandatory for this issue and also i need to publish the Talawa-Api
docker image on DockerHub.
It would only make sense for this issue if we publish the
Talawa-API
as a docker image on DockerHub, and then use it to setup the admin via Compose. Otherwise there is no need for the same as of now IMO.
This is what I intended to do
@palisadoes Can I have an update on this?
@palisadoes @Cioppolo14 @noman2002 Can I raise an issue for potential improvements to
Talawa-API
's Docker support? It's mandatory for this issue and also i need to publish theTalawa-Api
docker image on DockerHub.
We already have a docker API issue